546253 - moz_openpages_temp table needs to describe pages that may not be in moz_places

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Followup for bug 480350.

The moz_openpages_temp currently joins with moz_places based on ID. However, if an open page has been removed from history, then it won't register as being open, since there will be no corresponding row in moz_places to join with. 

To solve this, moz_openpages_temp could instead hold URL and title, and join based on URL.

Comment 3

[Johnathan Nightingale [:johnath]]

Definitely blocks, but we wouldn't hold beta1 for it

Comment 4

[eyal gruss]

is this also relevant for switching to "about:" pages, or should i file a separate bug for that?

Comment 5

[Marco Bonardo [:mak]]

this fix should work for about: pages afaict.

Comment 6

[Marco Bonardo [:mak]]

stealing for now, I need this sooner than later, due to add page contentions with async visitURI

Comment 7

[Shawn Wilsher :sdwilsh]

(In reply to comment #6)
> stealing for now, I need this sooner than later, due to add page contentions
> with async visitURI
Can you updated the dependencies?

Comment 8

[Marco Bonardo [:mak]]

(In reply to comment #7)
> (In reply to comment #6)
> > stealing for now, I need this sooner than later, due to add page contentions
> > with async visitURI
> Can you updated the dependencies?

bug 585966 is already in the blocks section of this bug, could also help bug 559217

Comment 9

[Marco Bonardo [:mak]]

sorry I meant bug 563538

Comment 10

[Marco Bonardo [:mak]]

Attachment: patch v1.0

Comment 11

[Marco Bonardo [:mak]]

Comment on attachment 464653 [details] [diff] [review]
patch v1.0

this also moves up results in the list, that was requested in another bug (but was easier to do it here).
The backend (register/unregister) part is something we want regardless, the ordering of the results changes here and would be nice to get users feedback.

Comment 12

[Shawn Wilsher :sdwilsh]

Comment on attachment 464653 [details] [diff] [review]
patch v1.0

r=sdwilsh

Comment 13

[Marco Bonardo [:mak]]

there is probably some glitch with about:blank registration since I see a related failure on tryserver:
http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTry/1281549452.1281550402.29118.gz TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/base/content/test/browser_tabMatchesInAwesomebar.js | tab is open (1 times) and should recorded in db: about:blank
Or it's just a timing issue of the test that should wait visits addition (bug 576605 has a wip patch for that).

Comment 14

[Marco Bonardo [:mak]]

the test failure is caused by bug 586506 (browser_bug380960.js is the origin of the unmatching tab).

Comment 15

[Marco Bonardo [:mak]]

Attachment: patch v1.1

switch to tab was covering a missing change in docshell, will try to get a diff review

Comment 16

[Marco Bonardo [:mak]]

Attachment: patch v1.2

just a fix to a comment.

Comment 17

[Marco Bonardo [:mak]]

Comment on attachment 465801 [details] [diff] [review]
patch v1.2

asking review on the small dochell change, the design of switch to tab was covering the fact docshell was still trying to set title synchronously before adding a page.

Comment 18

[Shawn Wilsher :sdwilsh]

Comment on attachment 465801 [details] [diff] [review]
patch v1.2

r=sdwilsh on the docshell changes

Comment 19

[Jeff Muizelaar [:jrmuizel]]

http://hg.mozilla.org/mozilla-central/rev/469328928474