Closed
Bug 546484
(NoC192SM)
Opened 14 years ago
Closed 14 years ago
Error out on building SeaMonkey with 1.9.2 from comm-central
Categories
(SeaMonkey :: Build Config, defect)
SeaMonkey
Build Config
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.1a1
People
(Reporter: kairo, Assigned: sgautherie)
References
Details
Attachments
(1 file, 1 obsolete file)
882 bytes,
patch
|
kairo
:
review+
|
Details | Diff | Splinter Review |
As we decided to unsupport 1.9.2 for SeaMonkey on comm-central, we should error out on building with 1.9.2 from that tree, so people do not end up with broken, unsupported configurations inadvertently.
Assignee | ||
Comment 1•14 years ago
|
||
Reporter | ||
Comment 2•14 years ago
|
||
Comment on attachment 427258 [details] [diff] [review] (Av1) Just error out > # Now is a good time to test for logic errors, define mismatches, etc. > case "$MOZ_BUILD_APP" in > xulrunner) > if test "$LIBXUL_SDK"; then > AC_MSG_ERROR([Building XULRunner --with-libxul-sdk doesn't make sense; XULRunner provides the libxul SDK.]) > fi > ;; >-esac Don't join those case statements, they are for different reasons, as the comments explain. I wonder if building XULRunner from comm-central makes any sense at all, actually, but that's a different bug. > # Special cases where we need to AC_DEFINE something. Also a holdover for apps > # that haven't made a confvars.sh yet. Don't add new stuff here, use > # MOZ_BUILD_APP. >-case "$MOZ_BUILD_APP" in > suite) >+ if test "$MOZILLA_1_9_2_BRANCH" = "1"; then >+ AC_MSG_ERROR([Building SeaMonkey with mozilla1.9.2 is not supported.]) >+ fi > AC_DEFINE(MOZ_SUITE) > ;; >- > mail) > AC_DEFINE(MOZ_THUNDERBIRD) > ;; >- > calendar) > AC_DEFINE(MOZ_SUNBIRD) > ;; >- > esac Please leave those newlines in. Also, did you try if we can do this in confvars.sh? If it works, I'd prefer that. The whole block of AC_DEFINEs here should actually go away at some stage, if possible...
Assignee | ||
Comment 3•14 years ago
|
||
Av1, with comment 2 suggestion(s). (In reply to comment #2) > I wonder if building XULRunner from comm-central makes any > sense at all, actually, but that's a different bug. Yeah, I thought about it too in the meantime... ;-) > Also, did you try if we can do this in confvars.sh? configure executes |. "${srcdir}/${MOZ_BUILD_APP}/confvars.sh"|. I have no idea how to error out (from) there. > The whole block of AC_DEFINEs here should actually go away at some stage, Does it really matter for this ("short lived") code?
Attachment #427258 -
Attachment is obsolete: true
Attachment #427354 -
Flags: review?(kairo)
Attachment #427258 -
Flags: review?(kairo)
Assignee | ||
Updated•14 years ago
|
Alias: NoC192SM
Severity: normal → major
Flags: in-testsuite-
Reporter | ||
Comment 4•14 years ago
|
||
Comment on attachment 427354 [details] [diff] [review] (Av2) Just error out [Checkin: Comment 5] Yes, I don't completely love it, but let's just do it.
Attachment #427354 -
Flags: review?(kairo) → review+
Assignee | ||
Comment 5•14 years ago
|
||
Comment on attachment 427354 [details] [diff] [review] (Av2) Just error out [Checkin: Comment 5] http://hg.mozilla.org/comm-central/rev/0cdce605ea0c
Attachment #427354 -
Attachment description: (Av2) Just error out → (Av2) Just error out
[Checkin: Comment 5]
Assignee | ||
Updated•14 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•14 years ago
|
Blocks: C192ConfSync
You need to log in
before you can comment on or make changes to this bug.
Description
•