Closed Bug 546500 Opened 14 years ago Closed 14 years ago

Display avm and asc version when running runtests.py.

Categories

(Tamarin Graveyard :: Tools, defect)

Product:
Tamarin Graveyard
Component:
Tools
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: cpeyer, Assigned: cpeyer)

Details

Attachments

(2 files)

Display avm and asc version in header
11.57 KB, patch
dschaffe
: review+
Details | Diff | Splinter Review
the vm variable name was incorrectly reused and therefore was being set in winmobile builds mistakenly to the filename.
1.33 KB, patch
dschaffe
: review+
Details | Diff | Splinter Review 
Nice-to-have: display the avm and asc versions when running runtests.py.
Patch to display version info in header.

Asc version is only displayed if -f or --rebuildtests is enabled, as otherwise we have no way of knowing what compiler version was used for existing .abc files.

Also cleaned up a little bit of code in performance/runtests.py that was using if len(var) > 0 to just test for the var.
Attachment #427213 - Flags: review?(brbaker)
Attachment #427213 - Flags: review?(brbaker) → review?(dschaffe)
Attachment #427213 - Flags: review?(dschaffe) → review+
Comment on attachment 427213 [details] [diff] [review]
Display avm and asc version in header

looks good.  I would run the patch through the sandbox to make sure winmo or platforms with no avm version work ok.  it would be nice if an abc embedded the version of compiler was used to build it.
Pushed to redux changeset:   3854:3411b0f0a17d
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
Attachment #428285 - Flags: review?(dschaffe) → review+
Pushed to redux: changeset:   3877:c6931403257e
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: