546886 - TM: remove scary live connect crap from call path

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Andreas Gal :gal]

/*
         * XXX this makes no sense -- why convert to function if clasp->call?
         * XXX better to call that hook without converting
         *
         * FIXME bug 408416: try converting to function, for API compatibility
         * if there is a call op defined.
         */
        if ((ops == &js_ObjectOps) ? clasp->call : ops->call) {
            ok = clasp->convert(cx, funobj, JSTYPE_FUNCTION, &v);
            if (!ok)
                goto out2;

            if (VALUE_IS_FUNCTION(cx, v)) {
                /* Make vp refer to funobj to keep it available as argv[-2]. */
                *vp = v;
                funobj = JSVAL_TO_OBJECT(v);
                parent = OBJ_GET_PARENT(cx, funobj);
                goto have_fun;
            }
        }

Comment 1

[Andreas Gal :gal]

Mike, what is the chance that we will need liveconnect for 1.9.3?

Comment 2

[Andreas Gal :gal]

Attachment: patch

Comment 3

[Brendan Eich [:brendan]]

Comment on attachment 427563 [details] [diff] [review]
patch

Bet this breaks LiveConnect, or once would have. Let's find out, on tm and m-c.

/be

Comment 4

[Andreas Gal :gal]

Blah, forgot to quote the bug # in the commit.

http://hg.mozilla.org/tracemonkey/rev/a4df44da864c

Comment 5

[Bob Clary [:bc] (inactive)]

This caused ecma/GlobalObject/15.1-2-n.js to crash.

regression changeset: 38099:a4df44da864c user: Andreas Gal <[e-mail]> date: Fri Feb 19 17:31:44 2010 -0800 summary: Remove LiveConnect kludge from call path (1.9.3 will not have LiveConnect according to jst, r=brendan).

Comment 6

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/a4df44da864c