546955 - Projects page search widgets are misaligned

Status: RESOLVED FIXED

(Websites Graveyard :: drumbeat.org, defect)

Description

[Gervase Markham [:gerv]]

There is ugliness on https://drumbeat.stage.mozilla.com/projects . The three search widgets (box, dropdown, button) are below and to the right of each other, when I would expect them to be in a line.

Browser: Firefox 3.6 on Ubuntu Linux 9.10.

Gerv

Comment 1

[Paul Booker]

This looks to have been resolved?

Comment 2

[Gervase Markham [:gerv]]

Attachment: Misaligned fields

This is what I see on that page when not logged in (Firefox 3.6, Ubuntu 9.10). 

When I log in as gerv, the dropdown changes to <Any> but the misalignment is still there.

When logged in as admin, the problem goes away. I instead see a search box and attached button, the dropdown and a View All Projects link, all in a line.

Gerv

Comment 3

[Matt Thompson]

I just confirmed that this is still a problem for anonymous users. See Gerv's screen grab -- just produced the same result. Ugliness indeed.

Comment 4

[Matt Thompson]

Note: page displays correctly when logged in as admin.

Comment 5

[Campbell Vertesi]

Flushed the cache, and it's fixed for me.

Comment 6

[jamey]

this is not resolved

Comment 7

[Gervase Markham [:gerv]]

This is clearly an intermittent bug. Next time someone sees it, they should do a Save Page As... (whole page) and see if they can capture the problem on disk. Then we can compare it with the working version to try and track the problem down.

Gerv

Comment 8

[Michael Priest]

This is fixed in svn.

Some styling wasn't being included on cached pages.

Comment 9

[Gervase Markham [:gerv]]

Mike: please can you attach patches to bugs you fix, as per
https://wiki.mozilla.org/Drumbeat/Website/Hacking
? Thanks :-)

I've svn updated the staging server. There was one change in 
sites/all/themes/drumbeat/css/style.css - presumably that's it?

Gerv

Comment 10

[Michael Priest]

Attachment: Patch from svn commit

Comment 11

[Michael Priest]

My apologies - didn't know that was procedure.
Is referencing the commit revision acceptable also?

Michael

Comment 12

[Gervase Markham [:gerv]]

Mike: no problem. Attaching the patch would generally be part of the review process; we aren't quite there yet with that, but it's good to start. 

Referencing the commit revision in the comment when you RESOLVE the bug is also good practice :-) I'll add that to the page.

Gerv

Comment 13

[Michael Priest]

No problem... we're using redmine, which is nice for the tight svn integration. You can reference tickets in your commit and the commit messages get displayed with the ticket. Likewise you can reverse reference too using the syntax below which will turn into a link to the revision changes in web gui. (I don't think it would scale... but hey :) )

See r63709 & r63710

Comment 14

[Matt Thompson]

This issue reoccurred for me when logged in as an authenticated user. Mar 8 5pm EST. Screen grab attached.

Comment 15

[Matt Thompson]

Attachment: search widgets misaligned

Comment 16

[Campbell Vertesi]

Looked at this today, confirmed that on live the projects page is borked for anonymous.  It works on staging however, and we confirmed that the CSS is different on the two sites.

Please SVN update on live server, clear caches and confirm if the problem is still there.

Comment 17

[Gervase Markham [:gerv]]

campbell: live server svn updates every 15 minutes from the "production" tag. mhaggerty is coordinating the moving of that tag. He's your man :-)

Gerv

Comment 18

[Matt Thompson]

Appears fixed.