54713 - Focus ring on folder pane causes pane to resize

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect, P2)

Description

[Mike Pinkerton (not reading bugmail)]

in the mac classic skin, the focus ring used for the folder pane causes it to
resize as it gain and loses the focus. This resizing is fairly slow and makes
clicking from a folder to the thread pane sluggish.

The folder pane doesn't appear to have this problem, the size of the focus ring
appears to have already been taken into account in the margins.

Comment 1

[Mike Pinkerton (not reading bugmail)]

Simple fix, big win in polish. nominating for rtm.

Comment 2

[Blake Ross]

->themes

Comment 3

[don]

Won't stop ship.  Minus.

Comment 4

[Mike Pinkerton (not reading bugmail)]

clearing rtm-. I have a patch, r=ben. this is very safe, and makes a big impact
on mac classic skin mail performance!

Index: mozilla/themes/classic/messenger/mac/messenger.css
===================================================================
RCS file: /m/pub/mozilla/themes/classic/messenger/mac/messenger.css,v
retrieving revision 1.5
diff -u -2 -r1.5 messenger.css
--- messenger.css	2000/09/14 19:02:16	1.5
+++ messenger.css	2000/10/06 02:53:04
@@ -414,13 +414,4 @@
  *Focus rings on 3 pane view
  */
-
-#folderTree{
-
border: 2px solid transparent !important;
-}
-
-#folderTree:focus{
-
border: 2px solid black !important;
-}
-

 .window-focusborder[focusring="true"]{

Index: mozilla/themes/classic/messenger/mac/folderPane.css
===================================================================
RCS file: /m/pub/mozilla/themes/classic/messenger/mac/folderPane.css,v
retrieving revision 1.3
diff -u -2 -r1.3 folderPane.css
--- folderPane.css	2000/08/17 23:48:37	1.3
+++ folderPane.css	2000/10/06 02:53:03
@@ -151,5 +151,5 @@
   }

-#folderTree, #folderTree > .tree-container-treerows
+#folderTree > .tree-container-treerows
   {
     border                : none !important;
@@ -162,3 +162,15 @@
     visibility            : hidden;
   }
-
+
+
+/**
+ *Focus rings on 3 pane view
+ */
+
+#folderTree{
+
border: 2px solid transparent !important;
+}
+
+#folderTree:focus{
+
border: 2px solid black !important;
+}

Comment 5

[don]

Well, looks like Pink came up with a patch himself.  That's motivation! :-)

Since Ben reviewed and approved the fix, I'll nominate this for review by the PDT.

PDT folks, this looks pretty safe and sane.  Please approve.

Comment 6

[Phil Peterson]

PDT marking [rtm need info] since there's only one reviewer. Need one more and
then we'll ++ it.

Comment 7

[Paul Chen]

looks good, r=pchen, adding myself to cc list

Comment 8

[Mike Pinkerton (not reading bugmail)]

r and a, patch included, moving back to rtm+

Comment 9

[Michael La Guardia]

marking rtm++

Comment 10

[Mike Pinkerton (not reading bugmail)]

taking back to land myself for ben

Comment 11

[Mike Pinkerton (not reading bugmail)]

landed on branch and trunk

Comment 12

[Patty Mac]

Verify ok on mac (2000-10-10-10-MN6)

Comment 13

[Mike Pinkerton (not reading bugmail)]

um, patty? how did you verify this if i checked in the fix 2 hours ago on the
branch and trunk? the 10am build certainly didn't have it...and it is certainly
not fixed in the 10am build I am using.

Comment 14

[Patty Mac]

I verified on Mac (20001-01-02-08-Mtrunk) and it seemed working normal.