547458 - Modern theme needs CSS for about:memory

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[[e-mail]]

Bug 520364 made it possible for themes to style about:memory

Comment 1

[Jens Hatlak (:InvisibleSmiley)]

Attachment: patch

I mostly just copy-pasted from mozilla/toolkit/components/aboutmemory/content/aboutMemory.css and Modern's about.css. I'm not a Modern expert.

Comment 2

[[e-mail]]

Comment on attachment 441614 [details] [diff] [review]
patch

r=me with a couple of nits fixed.

>+h1 {
>+  font-weight: bold;
>+  font-size: x-large;
>+}
Probably unnecessary; see below.

>+h2 {
>+  margin-top: 0;
>+  font-weight: bold;
>+  font-size: large;
>+}
The font-weight is of course unnecessary, since all headers default to bold. I don't see any advantage in changing the default sizes either. We probably need to keep the zero top margin though.

>+.memOverview table {
>+  font-size: 120%;
>+}
about.css uses 110% for something similar.

Comment 3

[[e-mail]]

Comment on attachment 441614 [details] [diff] [review]
patch

>+.memOverview table {
.memOverview > table

Comment 4

[Jens Hatlak (:InvisibleSmiley)]

Attachment: patch v2 [Checkin: comment 5]

Comment 5

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 443202 [details] [diff] [review]
patch v2 [Checkin: comment 5]

http://hg.mozilla.org/comm-central/rev/475ee6344218