Closed
Bug 547657
Opened 14 years ago
Closed 14 years ago
gfxSharedImageSurface.cpp failed to compile on Solaris
Categories
(Core :: Widget, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a3
People
(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)
References
Details
Attachments
(1 file, 1 obsolete file)
|
557 bytes,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
"../../../../gfx/thebes/src/gfxSharedImageSurface.cpp", line 64: Error: Formal argument 1 of type char* in call to shmdt(char*) is being passed unsigned char*.
man shmdt on Solaris
SYNOPSIS
#include <sys/types.h>
#include <sys/shm.h>
void *shmat(int shmid, const void *shmaddr, int shmflg);
int shmdt(char *shmaddr);
Standard conforming
int shmdt(const void *shmaddr);
I think we can cast to "char *", it should also work for the shmdt(void *) declaration.
|
||
Updated•14 years ago
|
Attachment #428154 -
Attachment is patch: true
Attachment #428154 -
Attachment mime type: application/octet-stream → text/plain
|
|
||
Updated•14 years ago
|
Version: unspecified → Trunk
|
||
Comment 2•14 years ago
|
||
I wonder if it would be better to just not build this file on Solaris. It shouldn't be needed there.
It is only needed for QT toolkit, right?
so
ifeq ($(MOZ_WIDGET_TOOLKIT),qt)
CPPSRCS += \
gfxSharedImageSurface.cpp \
$(NULL)
endif
Is it correct?From http://mxr.mozilla.org/mozilla-central/search?string=gfxSharedImageSurface It is only used by qt.
Attachment #429092 -
Flags: review?(jmuizelaar)
|
|
||
Updated•14 years ago
|
Attachment #429092 -
Flags: review?(jmuizelaar) → review+
Comment on attachment 428154 [details] [diff] [review] patch Not needed, unless use qt toolkit on Solaris.
Attachment #428154 -
Flags: review?(jmuizelaar)
http://hg.mozilla.org/mozilla-central/rev/b4f8880a80c2
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
|
||
Updated•14 years ago
|
Attachment #428154 -
Attachment is obsolete: true
|
|
||
Updated•14 years ago
|
Flags: in-testsuite-
Target Milestone: --- → mozilla1.9.3a3
You need to log in
before you can comment on or make changes to this bug.
Description
•