Closed
Bug 547685
Opened 14 years ago
Closed 14 years ago
[HTML5][Patch] parser/htmlparser/tests/mochitest/test_bug418464.html fails
Categories
(Core :: DOM: HTML Parser, defect, P1)
Tracking
()
RESOLVED
FIXED
People
(Reporter: hsivonen, Assigned: hsivonen)
Details
Attachments
(1 file)
736 bytes,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
140607 ERROR TEST-UNEXPECTED-FAIL | /tests/parser/htmlparser/tests/mochitest/test_bug418464.html | Should not have a form here - got [[object HTMLInputElement]], expected undefined
Assignee | ||
Comment 1•14 years ago
|
||
Assignee | ||
Updated•14 years ago
|
Summary: [HTML5] parser/htmlparser/tests/mochitest/test_bug418464.html fails → [HTML5][Patch] parser/htmlparser/tests/mochitest/test_bug418464.html fails
Comment 2•14 years ago
|
||
Comment on attachment 428180 [details] [diff] [review] Weaken the test not to require the first script to fail to find the form I would prefer that this become todo_is(form1 instanceof HTMLFormElement). r=bzbarsky with that.
Attachment #428180 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 3•14 years ago
|
||
(In reply to comment #2) > (From update of attachment 428180 [details] [diff] [review]) > I would prefer that this become todo_is(form1 instanceof HTMLFormElement). I can't make it a todo, since that would give an UNEXPECTED-PASS with the HTML5 parser. I could comment the line out and file a bug about uncommenting it in the future. Would your r hold for that?
Comment 4•14 years ago
|
||
Sounds good, yeah.
Assignee | ||
Comment 5•14 years ago
|
||
OK. The reminder bug is bug 547963.
Assignee | ||
Comment 6•14 years ago
|
||
Thanks. Pushed: http://hg.mozilla.org/mozilla-central/rev/62c81fdaeba1
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•