548218 - Reference to static function in function templates not allowed with Sun Studio compiler

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Ginn Chen]

"/export/home/slave/ffslave/mozilla-central-solaris-sparc/build/storage/src/variantToSQLiteT_impl.h", line 56: Error: Reference to static mozilla::storage::sqlite3_T_null(sqlite3_context*) not allowed in template mozilla::storage::variantToSQLiteT<sqlite3_context*>(sqlite3_context*, nsIVariant*), try using -features=tmplrefstatic.
"/export/home/slave/ffslave/mozilla-central-solaris-sparc/build/storage/src/variantToSQLiteT_impl.h", line 70: Error: Reference to static mozilla::storage::sqlite3_T_int(sqlite3_context*, int) not allowed in template mozilla::storage::variantToSQLiteT<sqlite3_context*>(sqlite3_context*, nsIVariant*), try using -features=tmplrefstatic.
"/export/home/slave/ffslave/mozilla-central-solaris-sparc/build/storage/src/variantToSQLiteT_impl.h", line 80: Error: Reference to static mozilla::storage::sqlite3_T_int64(sqlite3_context*, long long) not allowed in template mozilla::storage::variantToSQLiteT<sqlite3_context*>(sqlite3_context*, nsIVariant*), try using -features=tmplrefstatic.
"/export/home/slave/ffslave/mozilla-central-solaris-sparc/build/storage/src/variantToSQLiteT_impl.h", line 88: Error: Reference to static mozilla::storage::sqlite3_T_double(sqlite3_context*, double) not allowed in template mozilla::storage::variantToSQLiteT<sqlite3_context*>(sqlite3_context*, nsIVariant*), try using -features=tmplrefstatic.
"/export/home/slave/ffslave/mozilla-central-solaris-sparc/build/storage/src/variantToSQLiteT_impl.h", line 95: Error: Reference to static mozilla::storage::sqlite3_T_int(sqlite3_context*, int) not allowed in template mozilla::storage::variantToSQLiteT<sqlite3_context*>(sqlite3_context*, nsIVariant*), try using -features=tmplrefstatic.
"/export/home/slave/ffslave/mozilla-central-solaris-sparc/build/storage/src/variantToSQLiteT_impl.h", line 109: Error: Reference to static mozilla::storage::sqlite3_T_text(sqlite3_context*, const nsCString&) not allowed in template mozilla::storage::variantToSQLiteT<sqlite3_context*>(sqlite3_context*, nsIVariant*), try using -features=tmplrefstatic.
"/export/home/slave/ffslave/mozilla-central-solaris-sparc/build/storage/src/variantToSQLiteT_impl.h", line 123: Error: Reference to static mozilla::storage::sqlite3_T_text16(sqlite3_context*, const nsString&) not allowed in template mozilla::storage::variantToSQLiteT<sqlite3_context*>(sqlite3_context*, nsIVariant*), try using -features=tmplrefstatic.
"/export/home/slave/ffslave/mozilla-central-solaris-sparc/build/storage/src/variantToSQLiteT_impl.h", line 128: Error: Reference to static mozilla::storage::sqlite3_T_null(sqlite3_context*) not allowed in template mozilla::storage::variantToSQLiteT<sqlite3_context*>(sqlite3_context*, nsIVariant*), try using -features=tmplrefstatic.
"/export/home/slave/ffslave/mozilla-central-solaris-sparc/build/storage/src/variantToSQLiteT_impl.h", line 149: Error: Reference to static mozilla::storage::sqlite3_T_blob(sqlite3_context*, const void*, int) not allowed in template mozilla::storage::variantToSQLiteT<sqlite3_context*>(sqlite3_context*, nsIVariant*), try using -features=tmplrefstatic.
gmake[5]: *** [mozStorageConnection.o] Error 9

Comment 1

[Ginn Chen]

Attachment: patch

Comment 3

[Ginn Chen]

http://hg.mozilla.org/mozilla-central/rev/254cef95d664

Comment 4

[Ginn Chen]

Comment on attachment 428663 [details] [diff] [review]
patch

Required for 1.9.2 branch.

Comment 5

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1-CC) Copy it to comm-central, (m-1.9.2+) [Superseded by bug 574639]

Comment 6

[Justin Wood (:Callek)]

Comment on attachment 434299 [details] [diff] [review]
(Bv1-CC) Copy it to comm-central, (m-1.9.2+)
[Superseded by bug 574639]

caveat; do not land until after a 1.9.2 landing; rs+ if you want to ifdef this for 1.9.2 and land now, and rs+ for removing THAT ifdef once it does land; your choice.

Comment 7

[Daniel Veditz [:dveditz]]

Comment on attachment 428663 [details] [diff] [review]
patch

Clearing old approval requests now that 1.9.2.4 has shipped. If you believe this patch is still necessary on the 1.9.2 branch please re-request approval along with a risk/benefit analysis explaining why we need it.