548596 - opentochoice email sign up issues

Status: VERIFIED FIXED

(Websites Graveyard :: opentochoice.org, defect)

Description

[Jane Finette]

hi there 

Barbara just forwarded an email to me from a user who couldnt sign up on the website. 

Copied his email here:

I have just registered using my mail XXX.org from your page http://opentochoice.org/es/ without problems, but a first attempt failed using XXX.info (suggesting that e-mail addresses ending in 4 letters are not accepted), so an urgent note to your webmaster is advisable.

Can we check there are no issues please? There have also been reports via Asa that others have also been having some probs. (Asa could not replicate the issues). 

thanks 
jane

Comment 1

[Pascal Chevrel:pascalc (PTO until April 26)]

I confirm the issue with .info domains

Comment 2

[Pascal Chevrel:pascalc (PTO until April 26)]

Attachment: patch

Here is a patch fixing this issue by replacing the faulty regex by PHP's built-in email filtering function

Comment 3

[Javier Morales]

Fixed in r63298 please review

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #3)
> Fixed in r63298 please review

I got: 

"sign up confirmed

Thank you for signing up, we will send you more information when it's your time to choose and send you other news from Mozilla."

when using [e-mail], but I of course don't have a .info account/address with which to truly test.

Comment 5

[Staś Małolepszy :stas]

Seems like the original issue was that tld's with 4 letters or more weren't recognized as valid. It doesn't send anything yet, so the fix should be OK.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on staging; see comment 4.  I checked the admin panel, too, and my test address showed up there.