549097 - Multiple location bar results appear selected when scrolling down

Status: VERIFIED FIXED

(Core :: Graphics, defect)

Description

[u88484]

Multiple location bar results appear selected when scrolling down

STR:
1) Type g in location bar (or some other letter that you know will show a lot of results)
2) Press the down arrow key until the results begin to scroll
3) Note multiple results showing as being selected

This does not happen in the downloads manager.

Windows 7 64-bit
NVIDIA GeForce 7150M / nForce 630M
Drivers: 7.15.11.7967

Comment 1

[Josh Tumath]

Are they actually selected, or do they just appear as though they are?

Comment 2

[u88484]

Just appear.  The last selection is what opens up when the enter key is pressed.

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I can confirm this. Only seeing this after enabling Direct2D rendering.

Windows 7 x64
ATI Radeon HD5770
Driver 8.690.0.0

Comment 4

[u88484]

Could this bug be related to multiple ctrl+tab multiple selections?

http://img30.imageshack.us/img30/3489/ctrltab.jpg

Comment 5

[Bas Schouten (:bas.schouten)]

So, this is interesting, the window is scrolled up correctly, but it seems the part of the window containing the URL that used to be selected is not invalidated, so the unselected URL is never drawn there. I don't have a good idea yet what causes this.

Comment 6

[Bas Schouten (:bas.schouten)]

Attachment: AwesomebarScrollArtifact

Add a screenshot of the effect.

Comment 7

[Bas Schouten (:bas.schouten)]

Attachment: Fix scrolling invalidation for D2D

This patch fixes the invalidation when scrolling, by doing what ScrollWindowEx seems to do for the updateRgn. That is, it 'smears' the invalidation area with the scroll. I essentially takes the union of the current update region and the update region moves by the scroll.

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Can't you just move the region?

Comment 10

[Bas Schouten (:bas.schouten)]

Attachment: Fix scrolling invalidation for D2D v2

I believe that roc's right looking at our code. It doesn't seem to be what ScrollWindowEx does. But it seems to work just fine in all situations I tested, so I suggest we do this.

Comment 11

[Jeff Muizelaar [:jrmuizel]]

(In reply to comment #10)
> Created an attachment (id=430186) [details]
> Fix scrolling invalidation for D2D v2
> 
> I believe that roc's right looking at our code. It doesn't seem to be what
> ScrollWindowEx does. But it seems to work just fine in all situations I tested,
> so I suggest we do this.

Can't we just use OffsetRgn instead of doing this by hand?

Comment 12

[Bas Schouten (:bas.schouten)]

Attachment: Fix scrolling invalidation for D2D v3

Thanks for pointing me at the GDI function I couldn't find!!

Comment 13

[Bas Schouten (:bas.schouten)]

Pushed, changeset 103b23e9a222.

Comment 14

[Jim Jeffery not reading bug-mail 1/2/11]

Verified fixed using:

Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a3pre) Gecko/20100304 Minefield/3.7a3pre Firefox/3.6 ID:20100304141831 <latest hourly

cset: 20100304141831 5125fc26166b