549272 - mozilla.widget.render-mode should be initialized in all.js

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[John Daggett (:jtd)]

gfxWindowsPlatform::gfxWindowsPlatform reads in a pref 'mozilla.widget.render-mode', used for rendering.  The defaults are set here:

http://mxr.mozilla.org/mozilla-central/source/gfx/thebes/src/gfxWindowsPlatform.cpp#121

This logic should be in all.js also.

Comment 1

[Bas Schouten (:bas.schouten)]

This has never been the case in the past, although I'm not sure why. Is there a reason this wasn't done in the past, and if so, should we change it?

Comment 2

[Bas Schouten (:bas.schouten)]

Attachment: Initialize mozilla.widget.render-mode

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 429774 [details] [diff] [review]
Initialize mozilla.widget.render-mode

This is wrong, it should be initialized to -1 -- the default is different per platform at build time.

Comment 4

[Bas Schouten (:bas.schouten)]

Attachment: Initialize mozilla.widget.render-mode properly

Comment 5

[Bas Schouten (:bas.schouten)]

Pushed changeset a258698d412f.

Comment 6

[John Daggett (:jtd)]

Backed out
http://hg.mozilla.org/mozilla-central/rev/56c1507450be

Caused assertions to fire during mochitests:
###!!! ASSERTION: Invalid RenderMode!: 'Error', file e:/builds/moz2_slave/mozilla-central-win32-debug/build/widget/src/windows/nsWindowGfx.cpp, line 503

Comment 7

[Jonathan Kew [:jfkthame]]

That would be due to bug 549668.

Comment 8

[Jonathan Kew [:jfkthame]]

Re-landed this along with bug 549668.
http://hg.mozilla.org/mozilla-central/rev/8871f153c651