Closed
Bug 549693
Opened 14 years ago
Closed 14 years ago
[E10s] addMessageListener callback object should have access to browser object
Categories
(Core :: IPC, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: stechz, Assigned: smaug)
Details
Attachments
(1 file)
|
6.18 KB,
patch
|
jst
:
review+
|
Details | Diff | Splinter Review |
If addMessageListener is given an object, i.e. { receiveMessage: function() {} } its this pointer should point to that object, and its message parameter should have a "target" member that points to the browser element.
For callback functions passed to addMessageListener, the this object should be messageManager and the message parameter should also have a target member.
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → Olli.Pettay
|
|
Assignee | |
Updated•14 years ago
|
Summary: addMessageListener callback object should have access to browser object → [E10s] addMessageListener callback object should have access to browser object
|
|
Assignee | |
Comment 1•14 years ago
|
||
This adds .target to the message and changes 'this' handling to be closer to
event handlers:
if messageManager.addMessageListener("foo", function() {}) is used, then
'this' is the messageManager.
if messageManager.addMessageListener("foo", {receiveMessage: function() {}})
is used, then this is the object.
Attachment #429836 -
Flags: review?(jst)
|
||
Updated•14 years ago
|
Attachment #429836 -
Flags: review?(jst) → review+
|
|
Assignee | |
Comment 2•14 years ago
|
||
http://hg.mozilla.org/projects/electrolysis/rev/025d95e9aa36
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•