550080 - Movies.com trailers don't load in 3.6.x (doesn't affect all systems / intermittent effect)

Status: RESOLVED INCOMPLETE

(Core Graveyard :: Plug-ins, defect)

Description

[Charles]

Running movie trailers from Movies.com produces a window but the download does not start.

It is a regression in 3.6 and fixed in 3.7preAlpha

Comment 1

[Boris Zbarsky [:bzbarsky]]

Charles, can you point me to a url that shows this problem?

Comment 2

[Charles]

It doesn't really matter which video from what I could tell.  The video is embedded so the only link I can give you is http://www.movies.com/movie-trailers

Comment 3

[Boris Zbarsky [:bzbarsky]]

So I just tried 3.6.  I load the page, click the "A Nightmare on Elm Street: Trailer 2" thumbnail.  The trailer plays (though not centered in the space that opens up for it).

Are you seeing something different?  If so, how do I go about reproducing what you're seeing?

In case it matters, I'm on Mac; I can try Windows 7 tomorrow.

Comment 4

[Bob Clary [:bc] (inactive)]

I tried to bisect this on windows xp using the prince of persia trailer <http://www.movies.com/movie-trailers/prince-of-persia/1318621615/>. It appears to fail randomly for me so I am not entirely positive about my results. The first 1.9.2 build on 2009-08-13-12 showed the problem so any fix on 1.9.1 would have come after that I think. It seems to be fixed on trunk maybe sometime in 2010-01 maybe in the 2010-01-20 - 2010-01-31 range perhaps due to OOPP landings. If no one beats me to it, I'll bisect 1.9.1 during my unmetered access saturday night.

Comment 5

[Bob Clary [:bc] (inactive)]

Ok. looking solely at mozilla-central.

last good build: 2009-07-21-04 http://hg.mozilla.org/mozilla-central/rev/f2a58ffcd00c

first bad build: 2009-07-22-04 http://hg.mozilla.org/mozilla-central/rev/02f8bf10f441

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f2a58ffcd00c&tochange=02f8bf10f441

Comment 6

[Boris Zbarsky [:bzbarsky]]

Perhaps fallout from bug 339548?

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Roc: do you agree with comment 6?

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Yes.

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

OK, marking the regression, then. So, Roc, this is a bad functional regression; do we know what's needed to be done to fix it? I think this blocks, just trying to determine if I think it blocks .3 or some future dot release.

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Let's fix it for 1.9.3.

Comment 11

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I see this in mozilla-central with OOPP turned off.

However, I'm beginning to doubt it's bug 339548, because the plugin renders correctly --- the controls etc are just fine, events are dispatched correctly and the controls respond --- it just doesn't play the video.

Comment 12

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Also, the window structure and layout with and without OOPP is the same.

Comment 13

[Robert O'Callahan (:roc) (email my personal email if necessary)]

OTOH, nothing else in the changeset list would make sense.

Comment 14

[Robert O'Callahan (:roc) (email my personal email if necessary)]

The movies.com trailing is windowless (wmode=opaque). It's in an IFRAME, but loading the frame directly doesn't work either:
http://www.movies.com/HDFandangoPlayer.aspx?src=1434889748&movie=Iron%20Man%202&video=Iron%20Man%202:%20Trailer%202

Comment 15

[Mike Beltzner [:beltzner, not reading bugmail]]

Not blocking 1.9.2 since it's intermittent and the failure state is unclear at this time. Should that change, please renominate!

Comment 16

[Johnny Stenback (:jst)]

Blocking, beta1 for now, but feel free to push this further out if you think the fix isn't going to be very risky.