Closed
Bug 550362
Opened 14 years ago
Closed 14 years ago
Too much recursion through nsSVGEffects::InvalidateRenderingObservers with nested textPath
Categories
(Core :: SVG, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jruderman, Assigned: longsonr)
References
Details
(Keywords: crash, testcase)
Attachments
(2 files)
|
319 bytes,
image/svg+xml
|
Details | |
|
2.16 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
testcase (crashes Firefox when loaded)
The repeating part of the crash stack: 221 nsSVGEffects::InvalidateRenderingObservers(nsIFrame*) + 172 (nsSVGEffects.cpp:544) 222 nsSVGUtils::UpdateGraphic(nsISVGChildFrame*) + 56 (nsSVGUtils.cpp:670) 223 nsSVGGlyphFrame::SetGlyphPosition(float, float, int) + 92 (nsSVGGlyphFrame.cpp:916) 224 nsSVGTextFrame::UpdateGlyphPositioning(int) + 1156 (nsSVGTextFrame.cpp:407) 225 nsSVGTextFrame::NotifyGlyphMetricsChange() + 32 (nsSVGTextFrame.cpp:292) 226 nsSVGTextContainerFrame::NotifyGlyphMetricsChange() + 37 (nsSVGTextContainerFrame.cpp:61) 227 nsSVGTextPathProperty::DoUpdate() + 198 (nsSVGEffects.cpp:289) 228 nsSVGRenderingObserver::InvalidateViaReferencedFrame() + 44 (nsSVGEffects.cpp:171) 229 nsSVGRenderingObserverList::InvalidateAll() + 130 (nsSVGEffects.cpp:472) 230 nsSVGEffects::InvalidateRenderingObservers(nsIFrame*) + 172 (nsSVGEffects.cpp:544)
|
Assignee | |
Comment 1•14 years ago
|
||
The textPath change is not actually required but I was passing and it simplifies the code there. Moving the UpdateGraphic call is the thing that fixes the bug.
Assignee: nobody → longsonr
Attachment #430598 -
Flags: review?(roc)
Attachment #430598 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 2•14 years ago
|
||
checked in http://hg.mozilla.org/mozilla-central/rev/c04fe347f85d
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•