Closed Bug 550461 Opened 14 years ago Closed 14 years ago

[dashboard][shipping] pushes view busted for non-open milestones

Categories

(Mozilla Localizations :: Infrastructure, defect)

Product:
Mozilla Localizations
Component:
Infrastructure
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Pike, Assigned: Pike)

Details

https://l10n-stage-sj.mozilla.org/shipping/pushes?locale=ga-IE&av=tb3.1 is busted now that tb3.1 has no open milestone.

I see two things, firstly the signoff is retrieved from the milestone and not the appversion. The other is that ms.signoffs.get(locale=locale) doesn't have an exception handling for non-existing locales.
Taking. Not sure if I should touch the ms vs av stuff.
Assignee: nobody → l10n
Status: NEW → ASSIGNED
http://hg.mozilla.org/l10n/django-site/rev/6671dd4975c4, just added the exception handling.

The rest of the pushes view needs some cleanup and we'll need to throw a dice on whether to really remove the ms param code path or not. I'm tempted to do so.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.