550716 - There is a black line appears in Google.com fade effect

Status: RESOLVED FIXED

(Core :: Layout, defect, P2)

Description

[Can]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; tr; rv:1.9.3a3pre) Gecko/20100305 Minefield/3.7a3pre Firefox/3.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; tr; rv:1.9.3a3pre) Gecko/20100305 Minefield/3.7a3pre Firefox/3.6

Here is the Google's new fade effect at search page.

http://mashable.com/2009/12/02/google-fade-in/
http://www.seroundtable.com/archives/020907.html

At nightly trunk builds, when google.com fade effect begins, a black line appears under the search buttons. 

Here is the screenshot: http://i.imgur.com/lozEv.jpg


Reproducible: Always

Steps to Reproduce:
1.Open www.google.com, dont move the mouse cursor.
2. Move the mouse cursor
3. Black line appears under the search buttons. 

http://i.imgur.com/lozEv.jpg
Actual Results:  
There shouldn't be a black line.

Comment 1

[Can]

Attachment: screenshot

Comment 2

[Dave Garrett]

I'm seeing a black line too with latest Trunk under Linux. Confirming.

Comment 3

[Mats Palmgren (inactive)]

Fwiw, I tried the patch in bug 549630 - it did not help.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: testcase #2

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

The bug here is that we mark the layer for the translucent element as opaque because the associated display item is opaque, but the layer bounds have been set to the bounds of the display item, *rounded out*.

We should just snap the layer bounds to nearest pixel boundaries, instead. That's effectively what we used to do in nsDisplayOpacity::Paint.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Comment 7

[Mats Palmgren (inactive)]

Comment on attachment 431061 [details] [diff] [review]
fix

r=mats

Comment 8

[Dave Garrett]

Is this patch waiting on something to be committed?

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

It's waiting for the tree to be non-broken while I have to time to check stuff in.

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/mozilla-central/rev/20a2dea77cd3

Comment 11

[u88484]

Verified fixed using nightly build Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a3pre) Gecko/20100315 Minefield/3.7a3pre