550865 - Add Fennec strings for (CSP) Implement frame ancestor check

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sudarsana Nagineni]

The commit for bug 515458 broke Fennec because it added strings to appstrings/neterror and Fennec has a forked copy.

It's possible that this also broke Camino.

Comment 1

[Sudarsana Nagineni]

Attachment: copy firefox string changes from mozilla-central 0b3cd1b80f3c

hg diff -U1 -c 0b3cd1b80f3c browser/locales/en-US/chrome/overrides/appstrings.properties browser/locales/en-US/chrome/overrides/netError.dtd) |patch -p2

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #0)
> It's possible that this also broke Camino.

As long as bug 515458 is only going to be landed on the trunk, it doesn't break us until our trunk builds succeed, but thanks for the heads up!

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/ddf98c3daa80

Comment 4

[Aakash Desai [:aakashd]]

Is there a test page for CSP that I can verify this against?

Comment 5

[Brandon Sterne (:bsterne)]

http://people.mozilla.org/~bsterne/content-security-policy/tests/frame-ancestors-test.cgi

Comment 6

[Aakash Desai [:aakashd]]

Hm, the test case only passes for my trunk builds on winmo and maemo, but not on either of my 1.9.2 builds. If this landed on mobile-browser, it should be working on builds for both branches right?

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #6)
> Hm, the test case only passes for my trunk builds on winmo and maemo, but not
> on either of my 1.9.2 builds. If this landed on mobile-browser, it should be
> working on builds for both branches right?

No. The backend code is only on m-c

Comment 8

[Aakash Desai [:aakashd]]

verified FIXED On builds:

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a3pre) Gecko/20100311 Namoroka/3.7a3pre Fennec/1.1a2pre

and

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.3a3pre) Gecko/20100311 Namoroka/3.7a3pre Fennec/1.1a1