551084 - Add and update debug addons for Mozmill

Status: VERIFIED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

We should update the existing debug addons which we serve with Mozmill and add the following addons too:

* DOM Inspector
* Venkman

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

All those packages are included in jsbridge. So we have to upgrade the packages there and add DOMi.

Right now we have the following XPI's included:

chromebug-0.5.0a1.xpi
firebug-1.4.0a3.xpi
javascript_debugger-0.9.87.4-fx+tb+sb+sm.xpi
mozlab-current-0.1.9.2008050521.xpi
xush-0.2-fx.xpi

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

We should at least support DOMi and Venkman, which are the most useful extensions I have to use so far in identifying elements and stepping through tests.

Comment 3

[u279076]

(In reply to comment #2)
> We should at least support DOMi and Venkman, which are the most useful
> extensions I have to use so far in identifying elements and stepping through
> tests.

I second this motion!  DOMi is crucial to me debugging Mozmill tests and determining elements, properties, and attributes.  There is an inspector in Mozmill, but it pales in comparison to DOMi.

Comment 4

[cmtalbert]

This is all great and wonderful but there is no need to have these in the tarballs that we use for automated testing.  There they are just bloat.  Futhermore, the code doesn't currently install them, so I'm not exactly certain what good it does to update these.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Clint, those add-ons should only be bundled into Mozmill for the official release. We could create a script which fetches those extra add-ons and places them into the correct folder. As long as you do not execute that script those add-ons will not be there.

I think that would be a good way for making the tarballs small enough for buildbot.

Comment 6

[cmtalbert]

That sounds like a good idea, Henrik.  We're also moving toward a checked in flat file of mozmill code in m-c.  We'll need to talk about how to keep that in sync (and whether to keep it in sync and maintain one repo of mozmill code in git and the other in m-c).  Probably something for the newsgroup and not this bug though.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

For sure! But lemme give one last comment here which will help to clarify things eventually. We run Mozmill tests only with release builds of mozmill, jsbridge, and mozrunner. That way m-c never needs all the interim builds we produce on github. We only have to update the version on m-c when we have created a new version tag. Means we only have to move over changes once. IMO that's somekind easy. But yeah, please send a post to the mozmill-dev mailing list.

Comment 8

[Heather Arthur [:harth]]

proposing we ship with:

firebug-1.6.0a18.xpi
javascript_debugger-0.9.87.4-fx+tb+sb+sm.xpi
dom_inspector-2.0.7-fx+tb+sb+sm+fn.xpi


do we want chromebug or any of the others?

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I never managed (like others) to get chromebug working. I think we should be fine with the above mentioned add-ons.

Comment 10

[Heather Arthur [:harth]]

master
http://github.com/mozautomation/mozmill/commit/27075dd63bf02a9bf76b4940bf2e4a337ae9c188

1.4.2
http://github.com/mozautomation/mozmill/commit/8ee789a496cea1c543a947ec4e57b10b992daeae

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This is broken in current builds:

  File "/Volumes/data/build/tools/mozmill/jsbridge/jsbridge/__init__.py", line 118, in get_profile
    profile.install_addon(addon)
  File "/Volumes/data/build/tools/mozmill/mozrunner/mozrunner/__init__.py", line 202, in install_addon
    compressed_file = zipfile.ZipFile(addon, "r")
  File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/zipfile.py", line 685, in __init__
    self.fp = open(file, modeDict[mode])
IOError: [Errno 2] No such file or directory: '/Volumes/data/build/tools/mozmill/jsbridge/jsbridge/xpi/xush-0.2-fx.xpi'

Please update the following line in jsbridge/__init__.py:

    debug_addons = [os.path.join(parent, 'xpi', 'xush-0.2-fx.xpi')]

Xush is no longer part of Mozmill.

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Also we would have to iterate through all xpi files in that folder instead of specifying the files in that array. Please test with "mozmill --debug" with the next fix. Thanks.

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #10)
> master
> http://github.com/mozautomation/mozmill/commit/27075dd63bf02a9bf76b4940bf2e4a337ae9c188
> 
> 1.4.2
> http://github.com/mozautomation/mozmill/commit/8ee789a496cea1c543a947ec4e57b10b992daeae

Can we please continue to get reviews on patches? If we have binary components it would be nice to have at least a comment before a check-in. Thanks.

Comment 14

[Heather Arthur [:harth]]

fix in http://github.com/harthur/mozmill/compare/1.4.2...debugaddons

Comment 15

[Heather Arthur [:harth]]

Attachment: add all addons in xpi directory to debug_addons list

Comment 16

[Jeff Hammel]

Comment on attachment 463684 [details] [diff] [review]
add all addons in xpi directory to debug_addons list

>diff --git a/jsbridge/jsbridge/__init__.py b/jsbridge/jsbridge/__init__.py
>index 1398316..242fe7c 100644
>--- a/jsbridge/jsbridge/__init__.py
>+++ b/jsbridge/jsbridge/__init__.py
>@@ -105,8 +105,9 @@ class CLI(mozrunner.CLI):
>     parser_options[('-P', '--port')] = dict(dest="port", default="24242",
>                                             help="TCP port to run jsbridge on.")
>     
>-    debug_addons = [os.path.join(parent, 'xpi', 'xush-0.2-fx.xpi')]
>-    
>+    debug_addons = [os.path.abspath(os.path.join(parent,'xpi', x)) for x
>+                      in os.listdir(os.path.join(parent,'xpi'))] 
>+

You shouldn't need os.path.abspath since parent is already an absolute path.
r+ with this change

>     def get_profile(self, *args, **kwargs):
>         if self.options.debug:
>             kwargs.setdefault('preferences',

Comment 17

[Heather Arthur [:harth]]

(In reply to comment #16)
> Comment on attachment 463684 [details] [diff] [review]
> You shouldn't need os.path.abspath since parent is already an absolute path.
> r+ with this change

ah, thanks!

master:
http://github.com/mozautomation/mozmill/commit/a4c5aa4d310df94eae0697b6932ae7c01909d6ce

1.4.2:
http://github.com/mozautomation/mozmill/commit/91943023738f8f50e3c19dab8b2781240ea1d5c2

Comment 18

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Looks good now. Marking as verified fixed.

Comment 19

[Marc-Aurèle DARCHE]

While developing I'm using Console² cf. http://console2.mozdev.org/index.html a lot. Thus I would appreciate to have it available in Mozmill tests too.

I know that this bug's ticket is closed but I thought this was the best place to discuss the potential addition of Console² in a future version of Mozmill. So, what do you think?

Comment 20

[Marc-Aurèle DARCHE]

(In reply to comment #19)
> While developing I'm using Console² cf. http://console2.mozdev.org/index.html a
> lot. Thus I would appreciate to have it available in Mozmill tests too.
> 
> I know that this bug's ticket is closed but I thought this was the best place
> to discuss the potential addition of Console² in a future version of Mozmill.
> So, what do you think?

Replying to myself: 602284 adds the possibility the specify a directory containing all desired addons