Closed
Bug 551533
Opened 14 years ago
Closed 14 years ago
find_split should call StringMatch instead of rolling its own
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
1.73 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
This is the !re code at the bottom of the function.
Assignee | ||
Comment 1•14 years ago
|
||
Attachment #431682 -
Flags: review?(lw)
Updated•14 years ago
|
Attachment #431682 -
Flags: review?(lw) → review+
Comment 2•14 years ago
|
||
Comment on attachment 431682 [details] [diff] [review] Like so Cool, any speedup?
Assignee | ||
Comment 3•14 years ago
|
||
Sure; the first dromaeo-object-regexp test (which triggers this code) ends up about 70% faster.
Assignee | ||
Comment 4•14 years ago
|
||
Pushed http://hg.mozilla.org/tracemonkey/rev/910541364acc
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment 5•14 years ago
|
||
(In reply to comment #3) > Sure; the first dromaeo-object-regexp test (which triggers this code) ends up > about 70% faster. That'll do :)
Assignee | ||
Comment 6•14 years ago
|
||
Er, not in m-c yet...
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: fixed-in-tracemonkey
Comment 7•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/910541364acc
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•