Closed Bug 551533 Opened 14 years ago Closed 14 years ago

find_split should call StringMatch instead of rolling its own

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

This is the !re code at the bottom of the function.
Attached patch Like soSplinter Review
Attachment #431682 - Flags: review?(lw)
Attachment #431682 - Flags: review?(lw) → review+
Comment on attachment 431682 [details] [diff] [review]
Like so

Cool, any speedup?
Sure; the first dromaeo-object-regexp test (which triggers this code) ends up about 70% faster.
Pushed http://hg.mozilla.org/tracemonkey/rev/910541364acc
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
(In reply to comment #3)
> Sure; the first dromaeo-object-regexp test (which triggers this code) ends up
> about 70% faster.

That'll do :)
Er, not in m-c yet...
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/910541364acc
Status: REOPENED → RESOLVED
Closed: 14 years ago14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: