Closed Bug 551538 Opened 14 years ago Closed 13 years ago

browser_bookmarksProperties.js sporadically times out & fails with "We have finished editing folder name in folder tree"

Categories

(Toolkit :: Places, defect)

Product:
Toolkit
Component:
Places
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla2.0

People

(Reporter: dholbert, Assigned: mak)

References

(
URL
)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

use unload handler
6.70 KB, patch
sdwilsh
: review+
Details | Diff | Splinter Review 
browser_bookmarksProperties.js sporadically times out & fails a sub-test (in that order... not sure how that works)

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1268248281.1268250345.31830.gz
Linux mozilla-central debug test mochitest-other on 2010/03/10 11:11:21
s: moz2-linux-slave28

Failures are:
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js | Timed out
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js | We have finished editing folder name in folder tree

Note that other tests are started between those lines -- the second test happens after we've started browser_forgetthissite_single.js

More context:
{
TEST-PASS | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js | http://www.mozilla.org/ is a visited url.
JavaScript error: chrome://browser/content/places/bookmarkProperties.xul, line 1: gEditItemOverlay is null
JavaScript error: chrome://browser/content/places/bookmarkProperties.xul, line 1: gEditItemOverlay is null
--DOCSHELL 0xb519c70 == 7
++DOMWINDOW == 35 (0xbb39078) [serial = 505] [outer = 0xa716e20]
TEST-INFO | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js | Console message: [JavaScript Error: "gEditItemOverlay is null" {file: "chrome://browser/content/places/bookmarkProperties.xul" line: 1}]
TEST-INFO | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js | Console message: [JavaScript Error: "gEditItemOverlay is null" {file: "chrome://browser/content/places/bookmarkProperties.xul" line: 1}]
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js | Timed out
TEST-INFO | checking window state
Running chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_drag_bookmarks_on_toolbar.js...
[-------SNIP-------]
TEST-PASS | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js |  command 'placesCmd_createBookmark' on current selected node is enabled
pldhash: for the table at address 0xadae100, the given entrySize of 48 probably favors chaining over double hashing.
++DOCSHELL 0xadae098 == 8
++DOMWINDOW == 36 (0xb1b0bb8) [serial = 506] [outer = (nil)]
++DOMWINDOW == 37 (0xb4af0d0) [serial = 507] [outer = 0xb1b0b88]
TEST-INFO | checking window state
Running chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_forgetthissite_single.js...
Chrome file doesn't exist: /builds/slave/mozilla-central-linux-debug-unittest-mochitest-other/build/mochitest/browser/browser/components/places/tests/browser/head.js
TEST-PASS | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_forgetthissite_single.js | checking PlacesUtils, running in chrome context?
TEST-PASS | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_forgetthissite_single.js | http://www.mozilla.org/test1 successfully marked visited
TEST-PASS | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_forgetthissite_single.js | http://www.mozilla.org/test2 successfully marked visited
pldhash: for the table at address 0xbaeccb8, the given entrySize of 48 probably favors chaining over double hashing.
++DOCSHELL 0xbaecc50 == 9
++DOMWINDOW == 38 (0xbb68a10) [serial = 508] [outer = (nil)]
++DOMWINDOW == 39 (0xa4dd760) [serial = 509] [outer = 0xbb689e0]
pldhash: for the table at address 0xb8aad08, the given entrySize of 48 probably favors chaining over double hashing.
++DOCSHELL 0xb8aaca0 == 10
++DOMWINDOW == 40 (0xb6c6fd0) [serial = 510] [outer = (nil)]
++DOMWINDOW == 41 (0xb7258b8) [serial = 511] [outer = 0xb6c6fa0]
TEST-PASS | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js | EditItemOverlay is initialized
TEST-PASS | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_forgetthissite_single.js | The selected range is as big as expected
++DOMWINDOW == 42 (0xb0412c8) [serial = 512] [outer = 0xb6c6fa0]
TEST-PASS | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js | We are editing new folder name in folder tree
NEXT ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js | We have finished editing folder name in folder tree
TEST-PASS | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js | Dialog window should not be closed by pressing ESC in folder name textbox
}
Blocks: 438871
Whiteboard: [orange]
we saw a similar behavior in a sessionstore test, where the test due to server overload was just running damn slow. increasing the timeout in such a case solved the problem.
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1269872987.1269873844.25334.gz
TEST-INFO | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js | Console message: [JavaScript Warning: "Unknown property 'border-bottom-right-radius'.  Declaration dropped." {file: "http://www.mozilla.org/style/enhanced.css" line: 57}]
TEST-INFO | checking window state
TEST-INFO | (browser-test.js) | Waiting for window activation...
TEST-UNEXPECTED-FAIL | automation.py | application timed out after 330 seconds with no output
Whiteboard: [orange] → [orange][needs investigation]
I *think* http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1272557822.1272558647.27359.gz is this bug, but the symptoms are a little different:

TEST-INFO | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js | End of test:  Bug 491269 - Test that editing folder name in bookmarks properties dialog does not accept the dialog
TEST-INFO | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js | Console message: [JavaScript Warning: "Unknown property 'zoom'.  Declaration dropped." {file: "http://www.mozilla.org/style/screen.css" line: 90}]
TEST-INFO | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js | Console message: [JavaScript Warning: "Error in parsing value for 'letter-spacing'.  Declaration dropped." {file: "http://www.mozilla.org/style/screen.css" line: 349}]
TEST-INFO | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js | Console message: [JavaScript Warning: "Unknown property 'border-radius'.  Declaration dropped." {file: "http://www.mozilla.org/style/screen.css" line: 414}]
TEST-INFO | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js | Console message: [JavaScript Warning: "Unknown property 'border-radius'.  Declaration dropped." {file: "http://www.mozilla.org/style/enhanced.css" line: 44}]
TEST-INFO | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js | Console message: [JavaScript Warning: "Unknown property 'border-radius'.  Declaration dropped." {file: "http://www.mozilla.org/style/enhanced.css" line: 49}]
TEST-INFO | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js | Console message: [JavaScript Warning: "Unknown property 'border-top-right-radius'.  Declaration dropped." {file: "http://www.mozilla.org/style/enhanced.css" line: 53}]
TEST-INFO | chrome://mochikit/content/browser/browser/components/places/tests/browser/browser_bookmarksProperties.js | Console message: [JavaScript Warning: "Unknown property 'border-bottom-right-radius'.  Declaration dropped." {file: "http://www.mozilla.org/style/enhanced.css" line: 57}]
TEST-INFO | checking window state
TEST-INFO | (browser-test.js) | Waiting for window activation...
TEST-UNEXPECTED-FAIL | automation.py | application timed out after 330 seconds with no output
it's an hang at the end of the test, focus not going back to browser.
I think using unload handler here would be simpler and more reliable, I also found a handler was not correctly unregistered, but it's probably not reason for the failure.
So I think I'd like to take this patch and resolve the bug for now.
Attachment #515146 - Flags: review?(sdwilsh)
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Comment on attachment 515146 [details] [diff] [review]
use unload handler

r=sdwilsh
Attachment #515146 - Flags: review?(sdwilsh) → review+
http://hg.mozilla.org/mozilla-central/rev/779f2ca8eb0c

tentatively resolving
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [orange][needs investigation] → [orange]
Target Milestone: --- → mozilla2.0
Whiteboard: [orange]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: