Closed Bug 551569 Opened 14 years ago Closed 3 years ago

Error when debugging macros can affect control flow

Categories

(Developer Infrastructure :: Source Code Analysis, defect)

Product:
Developer Infrastructure
Component:
Source Code Analysis
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: cjones, Unassigned)

References

Details

It's pretty easy to make this mistake

  if (warning)
    NS_WARNING("warning");
  SomethingImportant();

In debug builds, this does the right thing, but in opt builds, that becomes

  if (warning)
    SomethingImportant();

Oops!

There's a site in dom/plugins/BrowserStreamChild.cpp where I did this, but it's hopefully being fixed by bsmedberg in some upcoming changes.
Actually, NS_WARNING() et al. prevent this from happening.  But I still think it's a useful analysis.  Not sure of the best problem definition and approach.
Product: Core → Firefox Build System

We have static-analysis for this right now.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INVALID
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.