55209 - menulists should use message-box font, not menu

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect, P2)

Description

[Simon Fraser [no longer active]]

Popups are using a huge, ugly font in todays tip o' the branch, modern skin. 
Screenshot coming...

Comment 1

[Simon Fraser [no longer active]]

Attachment: Screenshot of composer popup

Comment 2

[Simon Fraser [no longer active]]

ugly enough to need fixing for RTM, methinks.

Comment 3

[hangas]

These are huge, I was just reporting this myself and was told about this bug.  
This is causing some of the pref panels to be larger and therefore more 
information is dropped from the panel.

Comment 4

[Simon Fraser [no longer active]]

This also seriously impacts usability of mail compse. The addressing widget gets 
unusable.

Comment 5

[Joe Hewitt (gone)]

This problem is easily fixable.  We're using a new content model for buttons 
and menulists in order to make them scalable in 2 dimensions instead of just 
horizontally.  This involves using caps above and below the text.  The text 
can't overlay these caps, so there's an extra 7px of height.  It looks fine on 
Windows.  On the Mac, Charcoal has a larger ascent/descent than usual and so 
there's all that extra space.  I'm going to redo these bindings to use a stack 
instead.  Per discussion with Hyatt, this shouldn't affect performance.

Comment 6

[Joe Hewitt (gone)]

In Happy News, I have a fix for this waiting in the wings.  I had to re-do the 
binding for menulists and buttons, tweak the CSS a bit, and now the buttons 
size appropriately on mac and windows.  Hopefully I'll check this in today.  
I'll post the patch as soon as I fully test it.

Comment 7

[Simon Fraser [no longer active]]

*** Bug 55911 has been marked as a duplicate of this bug. ***

Comment 8

[Mike Pinkerton (not reading bugmail)]

hewitt, can you include a screenshot of the "new" buttons?

Comment 9

[Joe Hewitt (gone)]

This is now fixed on trunk and branch.

Comment 10

[Patty Mac]

verified ok on mac (2000-10-10-MN6).

Comment 11

[Simon Fraser [no longer active]]

reopening. I still think they are too big.
Popups (menulists) should use the window font, not the button font, I think.
They still look pretty much like the screenshot I attached, and make the
addressing widgets in mail compose too unweildy.

Comment 12

[hangas]

Need to mark this rtm-

Comment 13

[Joe Hewitt (gone)]

Simon/Pink, I'd like to mark this fixed, as I haven't heard anybody complain
about it since RTM.  Is that kosher with you or is there still a problem?  I
just checked in a fix for bug 16729, so system fonts are now used everywhere, so
that may help.

Comment 14

[Joe Hewitt (gone)]

Surveys of several Mac users indicate that the buttons/menulists are sized
properly. Marking fixed.

Comment 15

[Simon Fraser [no longer active]]

Whoa, I disagree (sorry for the delay in disagreeing!)

Popups and menulists should use the small system font by deafult (Geneva 10), and 
not the large font (Chicago 12 or whatever). Look at the addressing widget in 
mail; in Mozilla, this takes up huge amounts of space, compared to 4.x, because 
of the size of the popups. Similarly for the composer toolbar.

So make menulists and popups use the small system font by default.

Comment 16

[hangas]

Themes Triage Team P3

Comment 17

[Joe Hewitt (gone)]

Attachment: patch to fix

Comment 18

[Joe Hewitt (gone)]

Simon, can you please review the patch I just submitted? It should fix the
puffiness problems on buttons and menulists.

Comment 19

[Simon Fraser [no longer active]]

What is the "message-box" font? Is that the small application font (Geneva 10)?
Anyway, it looks *much* better. r=sfraser

Comment 20

[Joe Hewitt (gone)]

Yes, message-box corresponds to the "Small System Font" (Geneva), and menu
corresponds to the "Large System Font" (Charcoal) from the Appearances dialog.

Comment 21

[hangas]

a=hangas

Comment 22

[Joe Hewitt (gone)]

fixed

Comment 23

[Patty Mac]

Marking verified on Mac (2001-02-05-12-Mtrunk).