Closed
Bug 552241
Opened 14 years ago
Closed 14 years ago
nsIContentViewer::PermitUnload API has changed
Categories
(Camino Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: chris, Assigned: chris)
Details
(Whiteboard: [cm192test])
Attachments
(1 file, 1 obsolete file)
|
927 bytes,
patch
|
stuart.morgan+bugzilla
:
superreview+
|
Details | Diff | Splinter Review |
nsIContentViewer::PermitUnload now takes 2 parameters: a PR_Bool that "indicates that the current caller will close the window", plus the out parameter.
|
Assignee | |
Comment 1•14 years ago
|
||
Update code to use new function signature.
Assignee: nobody → trendyhendy2000
Status: NEW → ASSIGNED
Attachment #432375 -
Flags: superreview?(stuart.morgan+bugzilla)
|
||
Comment 2•14 years ago
|
||
Why PR_FALSE then? The only case we call PermitUnload ourselves is when closing a window/tab, which sounds like what this boolean is for.
|
|
Assignee | |
Comment 3•14 years ago
|
||
Yeah, looking at it again, that makes sense.
Attachment #432375 -
Attachment is obsolete: true
Attachment #432457 -
Flags: superreview?(stuart.morgan+bugzilla)
Attachment #432375 -
Flags: superreview?(stuart.morgan+bugzilla)
|
|
||
Comment 4•14 years ago
|
||
Comment on attachment 432457 [details] [diff] [review] Fix v.1.1 sr=smorgan
Attachment #432457 -
Flags: superreview?(stuart.morgan+bugzilla) → superreview+
Test repo: http://hg.mozilla.org/users/alqahira_ardisson.org/camino-1.9.2-test/rev/af2adcd3aab6
Whiteboard: [cm192test]
http://hg.mozilla.org/camino/rev/c964bca19ff1
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•