Closed Bug 552759 Opened 14 years ago Closed 14 years ago

Fix browser_signed_untrusted.js

Categories

(Toolkit :: Add-ons Manager, defect, P1)

defect

Tracking

()

VERIFIED FIXED
mozilla1.9.3a5

People

(Reporter: mossop, Assigned: mossop)

References

()

Details

(Whiteboard: [rewrite])

Attachments

(1 file)

      No description provided.
I couldn't see any litmus tests for signed extensions, it's probably worthwhile having a manual test for those in addition to the automated as the UI is important and it is a case rarely hit by nightly testers.
Flags: in-testsuite?
Flags: in-litmus?
Can you point me to some specs I can read to get familiar with it? That's not correlated to the website certificate, right?
Status: NEW → ASSIGNED
Signed extensions tell the user the XPI has not been tampered with since it was signed by someone they trust. Few extensions implement it, but thinkgs like Google Toolbar and I think LinkedIn show up the name of the signer during the install process. I need to provide some examples of cases where the signing is broken in some way too.
http://hg.mozilla.org/projects/addonsmgr/rev/32d8dc3a73bc adjusts the test so that it allows untrusted signers to just appear as if the XPI was unsigned, this is ok for now I think.
Flags: in-testsuite? → in-testsuite+
Whiteboard: [rewrite] → [rewrite][fixed-in-addonsmgr][needs-review]
Attached patch patch rev 1Splinter Review
JS code can't tell the difference between an unsigned XPI and one signed by an untrusted cert. I don't think there is much difference between the two as far as a user is concerned and dveditz agrees so this just makes the test check that the untrusted XPI appears as unsigned.
Attachment #435781 - Flags: review?(robert.bugzilla)
Attachment #435781 - Flags: review?(robert.bugzilla) → review+
Whiteboard: [rewrite][fixed-in-addonsmgr][needs-review] → [rewrite][fixed-in-addonsmgr]
Whiteboard: [rewrite][fixed-in-addonsmgr] → [rewrite][fixed-in-addonsmgr][needs-landing]
http://hg.mozilla.org/mozilla-central/rev/28bc763566de
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-litmus? → in-litmus-
Resolution: --- → FIXED
Whiteboard: [rewrite][fixed-in-addonsmgr][needs-landing] → [rewrite]
Target Milestone: --- → mozilla1.9.3a5
No orangeness. Marking as verified fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: