Closed Bug 552889 Opened 14 years ago Closed 14 years ago

numerous msgs fprintf()ed to the console, e.g. "(child won, so we're deferring)"

Categories

(Core :: IPC, defect)

1.9.2 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.3a5
Tracking Status
blocking1.9.2 --- -
status1.9.2 --- .5-fixed

People

(Reporter: grgoffe, Assigned: Gavin)

Details

Attachments

(1 file, 1 obsolete file)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a4pre) Gecko/20100316 Minefield/3.7a4pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a4pre) Gecko/20100316 Minefield/3.7a4pre

After starting firefox the following messages appear:

(<unknown>:5086): Gdk-CRITICAL **: gdk_window_get_origin: assertion `GDK_IS_WINDOW (window)' failed

(<unknown>:5086): Gdk-CRITICAL **: gdk_window_get_origin: assertion `GDK_IS_WINDOW (window)' failed

(<unknown>:5086): Gdk-CRITICAL **: gdk_window_get_origin: assertion `GDK_IS_WINDOW (window)' failed
  (child won, so we're not deferring)
  (child won, so we're deferring)
  (processing deferred in-call)
  (child won, so we're not deferring)
  (child won, so we're deferring)
  (processing deferred in-call)
  (child won, so we're not deferring)
  (child won, so we're deferring)
  (processing deferred in-call)
  (child won, so we're not deferring)
  (child won, so we're deferring)
  (processing deferred in-call)
  (child won, so we're deferring)
  (child won, so we're not deferring)
  (processing deferred in-call)
  (child won, so we're deferring)
  (child won, so we're not deferring)
  (processing deferred in-call)


Reproducible: Always

Actual Results:  
error msgs(?) appear.

Expected Results:  
no error msgs appear.

This system is up to date according to yum repos available.

shooter bash-4.0 ~# uname -a
Linux shooter.sleazegate.com 2.6.32.9-70.fc12.i686 #1 SMP Wed Mar 3 05:14:32 UTC 2010 i686 i686 i386 GNU/Linux
shooter bash-4.0 ~# cat /etc/redhat-release 
Fedora release 12 (Constantine)
The same problem exists with Fx 3.6.4 build1. Per gavin on IRC, this is not desired.
Status: UNCONFIRMED → NEW
blocking1.9.2: --- → ?
Ever confirmed: true
Version: unspecified → 3.6 Branch
Component: General → IPC
Product: Firefox → Core
QA Contact: general → ipc
Version: 3.6 Branch → 1.9.2 Branch
An annoyance; wanted, not blocking.
blocking1.9.2: ? → -
Attached patch remove fprintfs (obsolete) — Splinter Review
Is there any reason not to just remove these?

I left the ones in DumpRPCStack() and DebugAbort(), since I'm assuming they're only hit in exceptional circumstances.
Attachment #443754 - Flags: review?(jones.chris.g)
Comment on attachment 443754 [details] [diff] [review]
remove fprintfs

Yes, these are very useful when debugging.

Make these |if (LoggingEnabled())| please (see ipc/glue/ProtocolUtils.h).
Attachment #443754 - Flags: review?(jones.chris.g) → review-
Attached patch patchSplinter Review
Assignee: nobody → gavin.sharp
Attachment #443754 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #444207 - Flags: review?(jones.chris.g)
Comment on attachment 444207 [details] [diff] [review]
patch

Thanks.
Attachment #444207 - Flags: review?(jones.chris.g) → review+
Comment on attachment 444207 [details] [diff] [review]
patch

This should land for Fx 3.6.4/5 too.
Attachment #444207 - Flags: approval1.9.2.5?
Attachment #444207 - Flags: approval1.9.2.4?
Summary: numerous msgs "(child won, so we're deferring)" → numerous msgs fprintf()ed to the console, e.g. "(child won, so we're deferring)"
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/0de1a3677f6a
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
OS: Linux → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
Attachment #444207 - Flags: approval1.9.2.4?
Attachment #444207 - Flags: approval1.9.2.5? → approval1.9.2.5+
Comment on attachment 444207 [details] [diff] [review]
patch

a=beltzner for 1.9.2 default
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: