Closed
Bug 552970
Opened 14 years ago
Closed 14 years ago
download progress dialog doesn't remember position / coordinates
Categories
(SeaMonkey :: Download & File Handling, defect)
SeaMonkey
Download & File Handling
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.1a1
People
(Reporter: prof, Assigned: Callek)
Details
(Keywords: fixed-seamonkey2.0.5)
Attachments
(1 file, 1 obsolete file)
474 bytes,
patch
|
neil
:
review+
neil
:
superreview+
kairo
:
approval-seamonkey2.0.5+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.1.8) Gecko/20100205 Lightning/1.0b1 SeaMonkey/2.0.3 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.1.8) Gecko/20100205 Lightning/1.0b1 SeaMonkey/2.0.3 The download progress dialog doesn't seem to remember its position/coordinates, when being moved on the screen. On the next download it's centered again, which is pretting annoying when performing a dozen downloads a day. This is a regression compared to SM1.x if I'n not mistaken. Reproducible: Always Steps to Reproduce: 1. Download a file from the web 2. Move the progress dialog to other coordinates. 3. Download another file Actual Results: Next progess window appears centered again. Expected Results: Progress dialog opens with coordinates of last used position.
Assignee | ||
Updated•14 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Comment 1•14 years ago
|
||
In my (very limited) testing of SM 1.1.7 with regard to this, it does not appear to be a regression. However it does appear (easily) fixable. This patch should do it.
Assignee: nobody → bugspam.Callek
Status: NEW → ASSIGNED
Attachment #433108 -
Flags: superreview?(neil)
Attachment #433108 -
Flags: review?(neil)
Comment 2•14 years ago
|
||
Comment on attachment 433108 [details] [diff] [review] v1.0 -- use persist I don't think we want to persist all of these.
Comment 4•14 years ago
|
||
(In reply to comment #3) > May I ask what "sizemode" stands for? https://developer.mozilla.org/en/XUL:Attribute:sizemode
Assignee | ||
Comment 5•14 years ago
|
||
(In reply to comment #2) > (From update of attachment 433108 [details] [diff] [review]) > I don't think we want to persist all of these. Order of priority for this bug, for the persists: 1) ScreenX, ScreenY <--- Per Summary 2) Width, Height <--- I think also worth it 3) Sizemode <--- I was less certain to even include it. (In reply to comment #3) > May I ask what "sizemode" stands for? Sure, its basically, maximized vs positioned/windowed.
Assignee | ||
Comment 6•14 years ago
|
||
Attachment #433108 -
Attachment is obsolete: true
Attachment #433217 -
Flags: superreview?(neil)
Attachment #433217 -
Flags: review?(neil)
Attachment #433108 -
Flags: superreview?(neil)
Attachment #433108 -
Flags: review?(neil)
Updated•14 years ago
|
Attachment #433217 -
Attachment is patch: true
Attachment #433217 -
Attachment mime type: application/octet-stream → text/plain
Updated•14 years ago
|
Attachment #433217 -
Flags: superreview?(neil)
Attachment #433217 -
Flags: superreview+
Attachment #433217 -
Flags: review?(neil)
Attachment #433217 -
Flags: review+
Assignee | ||
Comment 7•14 years ago
|
||
Pushed as http://hg.mozilla.org/comm-central/efae333beb46
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 8•14 years ago
|
||
Comment on attachment 433217 [details] [diff] [review] v2 -- just screenx and screeny Low-Risk, actually would make this work better for some 2.0 users.
Attachment #433217 -
Flags: approval-seamonkey2.0.5?
Updated•14 years ago
|
Target Milestone: --- → seamonkey2.1a1
Updated•14 years ago
|
Attachment #433217 -
Flags: approval-seamonkey2.0.5? → approval-seamonkey2.0.5+
Comment 9•14 years ago
|
||
Comment on attachment 433217 [details] [diff] [review] v2 -- just screenx and screeny It's a functionality change, and I'm a bit reluctant to allow those on a stable branch, but it's so simple, so let's just do it.
Assignee | ||
Comment 10•14 years ago
|
||
Heh, slipped through my todo-cracks: Pushed as: http://hg.mozilla.org/releases/comm-1.9.1/rev/9b39f09b7ccd
Keywords: fixed-seamonkey2.0.5
You need to log in
before you can comment on or make changes to this bug.
Description
•