553964 - Port |Bug 550468 - Fix support for Pango font engine on Qt platform| to comm-central

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Justin Wood (:Callek)]

+++ This bug was initially created as a clone of Bug #550468 +++

Serge created attachment 430953 [details] [diff] [review] in that bug. Creating a spinoff bug was requested:

(In reply to comment #7)
> Created an attachment (id=430953) [details]
> (Cv1-CC) Port (the useful part of) it to comm-central, Restore (now) useful
> MOZ_PANGO support

(In reply to comment #10)
> (In reply to comment #8)
> 
> > Why we are making duplicate fixes for m-c and comm-c all the time? can we just
> 
> Because, afaik, that's how it works currently.
> 
> > build common-central by using SDK (build tree m-c without .cpp files) from m-c?
> 
> I'd be happy if the process could be improved: input welcomed...

(In reply to comment #12)
> (From update of attachment 430953 [details] [diff] [review])
> Why do we need Pango in c-c configure.in. if confvars.sh allows us to set it;
> and we still pass the --enable/disable args we should be safe here, no?
> 
> If there isn't really a reason, can you submit me a new patch that just drops
> the following from c-c.
> 
> > dnl = Pango
> > dnl ========================================================
> > if test "$MOZ_ENABLE_GTK2"
> > then
> >     PKG_CHECK_MODULES(MOZ_PANGO, pango >= $PANGO_VERSION pangoft2 >= $PANGO_VERSION)
> >     AC_SUBST(MOZ_PANGO_LIBS)
> > fi

(In reply to comment #13)
> I was not touching GTk2 port, if you want some changes for existing code, then
> file new bug with patch, and ask it for review from module owner.

(In reply to comment #14)
> (From update of attachment 430953 [details] [diff] [review])
> 
> (In reply to comment #12)
> 
> > (From update of attachment 430953 [details] [diff] [review] [details])
> > Why do we need Pango in c-c configure.in. if confvars.sh allows us to set it;
> > and we still pass the --enable/disable args we should be safe here, no?
> 
> Why disallow mozconfig use?
> 
> > If there isn't really a reason, can you submit me a new patch that just drops
> > the following from c-c.
> > 
> > > dnl = Pango
> > > dnl ========================================================
> > > if test "$MOZ_ENABLE_GTK2"
> > > then
> > >     PKG_CHECK_MODULES(MOZ_PANGO, pango >= $PANGO_VERSION pangoft2 >= $PANGO_VERSION)
> > >     AC_SUBST(MOZ_PANGO_LIBS)
> > > fi
> 
> This block is the very reason for this port: c-c uses MOZ_PANGO_LIBS.
> http://mxr.mozilla.org/comm-central/search?string=MOZ_PANGO_LIBS&case=on

Lets use this bug for further info on that....

Serge can you please re-attach the patch here...for its push (its r+)

Comment 1

[Serge Gautherie (:sgautherie)]

http://hg.mozilla.org/comm-central/rev/43e37e9ac452
(Av1) Port (the useful part of) it, Restore (now) useful MOZ_PANGO support.

NB: With added |"$MOZILLA_1_9_2_BRANCH" != "1"|.

Comment 2

[Mark Banner (:standard8)]

This has broken the Thunderbird + SeaMonkey boxes.

Comment 3

[Serge Gautherie (:sgautherie)]

(In reply to comment #2)

http://hg.mozilla.org/comm-central/rev/119eba2ab719
(Bv1) Add a |true| in configure.in.