554599 - [Edit Contributions Page] ambiguous error message is displayed while entering invalid values in suggested amount field

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P3)

Description

[Pratibha]

Attachment: image shows the error message coming up with invalid input in suggested amount field

Steps:
1)Login to Developer account at: https://preview.addons.mozilla.org
2)Click My Account->My Add-ons links
3)Click on "Edit Add-on" link for one of the hosted add-on in your account
4)In Edit <add-on name> page: Click on "Manage Contributions"
5)Under "Asking for Contributions" section: Enter incorrect suggested amount
say example: abc
7)Click on "Update Contributions"

Result: Error message displayed with invalid input in Suggested amount field is "Should be a positive number between 0.00 and 99.99.".
This message is confusing, from the message it seems that not more than $99.99 should be given as Suggested Donation amount

Comment 1

[Justin Scott [:fligtar]]

Error message should be "Please enter a suggested amount less than $1000."

Comment 2

[Wil Clouser [:clouserw]]

This bug is just a text change.

Comment 3

[Barry Chen]

Judging from the date of the bug and the vastly different contribution edit form I see in the devhub, this was a Remora issue.  Now entering 'abc' produces an error message.  But the form didn't check the suggested amount against the max contribution amount.  Added in http://github.com/chenba/zamboni/commit/c716b5c748c894ba32faa439b343c2490ee0e33d

Comment 4

[Jeff Balogh (:jbalogh)]

That looks good. I think this fixes bug 605681, or that can be a dupe here.

Comment 6

[Wil Clouser [:clouserw]]

(In reply to comment #4)
> That looks good. I think this fixes bug 605681, or that can be a dupe here.

Yes!  I was looking for that

Comment 7

[Barry Chen]

Pushed to jbalogh/master: https://github.com/jbalogh/zamboni/commit/ff0718d2983c7b508fdde146e9b374f35493d130

Comment 8

[krupa raj[:krupa]]

verified fixed @ https://addons-next.allizom.org/z/en-US/developers/addon/64249/payments

User message now says- "Please enter a suggested amount less than $1000."

Comment 9

[krupa raj[:krupa]]

Attachment: post-fix screenshot