554831 - make sure that our promise callbacks run in a runloop

Status: RESOLVED INVALID

(Skywriter Graveyard :: General, defect, P1)

Description

[Kevin Dangoor]

Right now, it's very easy to forget to wrap async results in a runloop to allow 
the UI and properties to get updated properly. Since we use promises 
consistently, if we make sure that promises callbacks execute in a runloop, we 
can eliminate that source of pain.

We should check (via SC.none(SC.RunLoop.currentRunLoop)) to see if we're in a 
runloop currently. If not, wrap the function call in an SC.run().

Once we've done this, we can remove the SC.run calls in the link() method as 
well as in several commands (just search for SC.run and see if that's happening 
in a promise callback).

Comment 1

[Gordon P. Hemsley [:GPHemsley]]

Is this still relevant?

Comment 2

[Kevin Dangoor]

No, not relevant any more since the runloop was specific to SproutCore.