555508 - The 'active' attribute is gone, should instead use -moz-window-inactive pseudoclass

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[Stefan [:stefanh]]

Attachment: fix style rules

The -moz-window-inactive pseudoclass introduced in bug 508482 made some styles rules in mac classic obsolete (they doesn't work anymore since the xul attribute was removed). We should use the new pseudoclass instead.

Comment 1

[Stefan [:stefanh]]

-#messengerWindow:not([active="true"]) > #mailContent > #messengerBox > #folderPaneBox {
+#folderPaneBox:-moz-window-inactive {
   background-color: #E8E8E8;
 }


As a curiosity, the old rule doesn't work on 2.0.x. Maybe caused by tabmail?

Comment 2

[Stefan [:stefanh]]

(In reply to comment #1)
> As a curiosity, the old rule doesn't work on 2.0.x. Maybe caused by tabmail?

Yep, caused by tabmail. Filed bug 555582 for a branch-fix.

Comment 3

[Stefan [:stefanh]]

Attachment: New version with pageInfo and DM as well

Turns out that I forgot pageInfo and DM :-/

Comment 4

[Stefan [:stefanh]]

Attachment: Updated for bitrot

Comment 5

[Stefan [:stefanh]]

Comment on attachment 436457 [details] [diff] [review]
Updated for bitrot

I bitrotted myself in bug 556102...

Comment 6

[[e-mail]]

Comment on attachment 436457 [details] [diff] [review]
Updated for bitrot

>-#main-window:not([active="true"]) > #navigator-toolbox > #nav-bar > #nav-bar-inner,
>-#main-window:not([active="true"]) > #navigator-toolbox > #nav-bar > toolbaritem,
>-#main-window:not([active="true"]) > #navigator-toolbox > #PersonalToolbar,
>-#main-window:not([active="true"]) > #navigator-toolbox > #linktoolbar {
>-  opacity: 0.75;
Out of interest, why these particular elements only?

Comment 7

[Stefan [:stefanh]]

The primary toolbar handles this itself and so does an added toolbar. We want this in the urlbar and in the throbber, though.

The PT and link toolbar are not native-styled, so we need the "fading" there.

Comment 8

[Stefan [:stefanh]]

http://hg.mozilla.org/comm-central/rev/17735b9dc0ba