555584 - startup crash nsBayesianFilter::nsBayesianFilter via nsBayesianFilterConstructor

Status: RESOLVED INCOMPLETE

(MailNews Core :: Filters, defect)

Description

[Wayne Mery (:wsmwk)]

crash  [@ nsBayesianFilter::nsBayesianFilter()]
crash is almost non-existent, 6 in past month
 https://crash-stats.mozilla.com/report/list?product=Thunderbird&build_id=&query_search=signature&query_type=exact&query=nsBayesianFilter%3A%3AnsBayesianFilter%28%29&date=&range_value=4&range_unit=weeks&process_type=all&plugin_field=&plugin_query_type=&plugin_query=&do_query=1&signature=nsBayesianFilter%3A%3AnsBayesianFilter%28%29&missing_sig=&page=1

first crash found is march 4, 2010. all are v3.0

this stack comes in 2 flavors. short, and long (and no extensions)

bp-af7a6a17-7876-41e9-81d6-ffa822100304 (short)
0	thunderbird.exe	nsBayesianFilter::nsBayesianFilter	 mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp:1230
1	thunderbird.exe	nsBayesianFilterConstructor	mailnews/build/nsMailModule.cpp:445
2	xpcom_core.dll	nsGenericFactory::CreateInstance	objdir-tb/mozilla/xpcom/build/nsGenericFactory.cpp:80
3	xpcom_core.dll	nsComponentManagerImpl::CreateInstance	xpcom/components/nsComponentManager.cpp:1601
4	xpcom_core.dll	nsComponentManagerImpl::GetService	xpcom/components/nsComponentManager.cpp:1903
5	thunderbird.exe	nsJSCID::GetService	js/src/xpconnect/src/xpcjsid.cpp:891 

bp-5bc06916-570f-4466-b12c-cf9192100322 (long and no extensions)
0	thunderbird.exe	nsBayesianFilter::nsBayesianFilter	 mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp:1220
1	thunderbird.exe	nsBayesianFilterConstructor	mailnews/build/nsMailModule.cpp:445
2	xpcom_core.dll	nsGenericFactory::CreateInstance	objdir-tb/mozilla/xpcom/build/nsGenericFactory.cpp:80
3	xpcom_core.dll	nsComponentManagerImpl::CreateInstance	xpcom/components/nsComponentManager.cpp:1601
4	xpcom_core.dll	nsComponentManagerImpl::GetService	xpcom/components/nsComponentManager.cpp:1903
5	thunderbird.exe	nsJSCID::GetService	js/src/xpconnect/src/xpcjsid.cpp:891
6	xpcom_core.dll	NS_InvokeByIndex_P	xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:102
7	thunderbird.exe	XPCWrappedNative::CallMethod	js/src/xpconnect/src/xpcwrappednative.cpp:2456
8	thunderbird.exe	XPC_WN_CallMethod	js/src/xpconnect/src/xpcwrappednativejsops.cpp:1590
9	js3250.dll	js_Invoke	js/src/jsinterp.cpp:1386
10	js3250.dll	js_Interpret	js/src/jsinterp.cpp:5179
11	js3250.dll	js_Execute	js/src/jsinterp.cpp:1622
12	js3250.dll	JS_ExecuteScript	js/src/jsapi.cpp:5037
13	xpcom_core.dll	nsQueryInterfaceWithError::operator	objdir-tb/mozilla/xpcom/build/nsCOMPtr.cpp:75
14	xpcom_core.dll	nsQueryInterfaceWithError::operator	objdir-tb/mozilla/xpcom/build/nsCOMPtr.cpp:75
15	thunderbird.exe	nsCSSFontFaceStyleDecl::GetLength	layout/style/nsCSSRules.cpp:1718
16	xpcom_core.dll	nsACString_internal::Finalize	xpcom/string/src/nsTSubstring.cpp:205
17		@0x3221d83	
18		@0x467e81f	
19	xpcom_core.dll	nsAString_internal::Assign	xpcom/string/src/nsTSubstring.cpp:361
20	thunderbird.exe	nsISupportsHashKey::nsISupportsHashKey	caps/include/nsScriptSecurityManager.h:101
21	thunderbird.exe	nsBaseHashtableET<nsURIHashKey,unsigned int>::nsBaseHashtableET<nsURIHashKey,unsigned int>	objdir-tb/mozilla/dist/include/xpcom/nsBaseHashtable.h:301
22	thunderbird.exe	nsTHashtable<nsBaseHashtableET<nsHashableHashKey,mozJSComponentLoader::ModuleEntry*> >::s_InitEntry	objdir-tb/mozilla/dist/include/xpcom/nsTHashtable.h:406
23	xpcom_core.dll	PL_DHashTableOperate	objdir-tb/mozilla/xpcom/build/pldhash.c:655
24	xpcom_core.dll	nsQueryInterfaceWithError::operator	objdir-tb/mozilla/xpcom/build/nsCOMPtr.cpp:75
25	thunderbird.exe	mozJSComponentLoader::ImportInto	js/src/xpconnect/loader/mozJSComponentLoader.cpp:1562
26	thunderbird.exe	mozJSComponentLoader::Import	js/src/xpconnect/loader/mozJSComponentLoader.cpp:1504
27	thunderbird.exe	nsXPCComponents_Utils::Import	js/src/xpconnect/src/xpccomponents.cpp:3663
28	xpcom_core.dll	NS_InvokeByIndex_P	xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:102
29	thunderbird.exe	XPCWrappedNative::CallMethod	js/src/xpconnect/src/xpcwrappednative.cpp:2456
30	thunderbird.exe	XPC_WN_CallMethod	js/src/xpconnect/src/xpcwrappednativejsops.cpp:1590
31	js3250.dll	js_Invoke	js/src/jsinterp.cpp:1386
32	js3250.dll	js_Interpret	js/src/jsinterp.cpp:5179
33	js3250.dll	js_Execute	js/src/jsinterp.cpp:1622
34	js3250.dll	JS_ExecuteScript	js/src/jsapi.cpp:5037
35	xpcom_core.dll	nsQueryInterfaceWithError::operator	objdir-tb/mozilla/xpcom/build/nsCOMPtr.cpp:75
36	xpcom_core.dll	nsQueryInterfaceWithError::operator	objdir-tb/mozilla/xpcom/build/nsCOMPtr.cpp:75

Comment 1

[Wayne Mery (:wsmwk)]

mostly startup crashes

example bp-6a4fc577-2a6b-480b-af6e-fc0db2110401
EXCEPTION_ACCESS_VIOLATION_WRITE
0x1
0	thunderbird.exe	nsBayesianFilter::nsBayesianFilter	mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp:1269
1	thunderbird.exe	nsBayesianFilterConstructor	mailnews/build/nsMailModule.cpp:449
2	xpcom_core.dll	nsGenericFactory::CreateInstance	objdir-tb/mozilla/xpcom/build/nsGenericFactory.cpp:80
3	xpcom_core.dll	nsComponentManagerImpl::CreateInstance	xpcom/components/nsComponentManager.cpp:1597
4	xpcom_core.dll	nsComponentManagerImpl::GetService	xpcom/components/nsComponentManager.cpp:1901
5	thunderbird.exe	nsJSCID::GetService	js/src/xpconnect/src/xpcjsid.cpp:894
6	xpcom_core.dll	NS_InvokeByIndex_P	xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:102
7	thunderbird.exe	XPCWrappedNative::CallMethod	js/src/xpconnect/src/xpcwrappednative.cpp:2722
8	thunderbird.exe	XPC_WN_CallMethod	js/src/xpconnect/src/xpcwrappednativejsops.cpp:1740
9	js3250.dll	js_Invoke	js/src/jsinterp.cpp:1360

Comment 2

[Wayne Mery (:wsmwk)]

signature is now mozalloc_abort(char const* const) | mozalloc_handle_oom(unsigned int) | moz_xmalloc | nsTArray_base<nsTArrayInfallibleAllocator>::EnsureCapacity(unsigned int, unsigned int) | nsBayesianFilter::nsBayesianFilter()
bp-0e1bcf10-fb2d-43b3-9180-c18442130129

Comment 3

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

I'm marking this bug as WORKSFORME as bug crashlog signature didn't appear from a long time (over half year).

Comment 4

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Ups, my bad and due to ( bug #1348631 ) looks like there are sill crashes, so reopening.

Comment 5

[Wayne Mery (:wsmwk)]

bp-e8a55008-831b-4537-98e4-ba6d12170228
0 	xul.dll	nsBayesianFilter::nsBayesianFilter()	c:/builds/moz2_slave/tb-rel-c-esr45-w32_bld-0000000/build/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp:1120
1 	xul.dll	nsBayesianFilterConstructor	c:/builds/moz2_slave/tb-rel-c-esr45-w32_bld-0000000/build/mailnews/build/nsMailModule.cpp:539 

crash is on an "if"

https://hg.mozilla.org/releases/comm-esr45/file/tip/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp#l1120
    int32_t junkThreshold = 0;
    nsresult rv;
    nsCOMPtr<nsIPrefBranch> pPrefBranch(do_GetService(NS_PREFSERVICE_CONTRACTID, &rv));
    if (pPrefBranch)

Comment 6

[Wayne Mery (:wsmwk)]

In last 6 months 5 crashes are version 52.x. 3 are linux with unity add-on. No v60 crashes so it may be gone. If not I don't think this bug is actionable.