556480 - AutoCompleteUtils error

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Error: AutoCompleteUtils: Could not write to cache file: [Exception... "Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIFileOutputStream.init]"  nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)"  location: "JS frame :: file:///home/steakdepapillon/Devel/fennec/mobilebase/mobile/dist/bin/components/AutoCompleteCache.js :: saveCache :: line 182"  data: no]
Source File: file:///home/steakdepapillon/Devel/fennec/mobilebase/mobile/dist/bin/components/AutoCompleteCache.js
Line: 192

Since a few days I seeing this a lot

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Does this happen only at startup every time? Only at startup after a new build?

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

I'm seeing it every times on desktop but only after a delay, not at startup, I'll try to pay more attention to it next time.
(I wonder if this file is corrupted or not on my computer)

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

I introduced this error when I added the bookmark listener. The AutoCompleteUtils class is not initialized so the file is null.

This patch puts a check to not initialize twice and it initializes from the bookmark listener.

Tests run without any errors now.

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 440765 [details] [diff] [review]
patch

Good catch!

I'll see in the next few day if I see the error again.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/ef28c4586cc5