Closed
Bug 556721
Opened 14 years ago
Closed 12 years ago
Clean up Places tests
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
People
(Reporter: mak, Unassigned)
References
Details
Attachments
(1 file)
|
7.21 KB,
patch
|
sdwilsh
:
review+
|
Details | Diff | Splinter Review |
Now that bug 556376 landed we cna remove a bunch of boilerplate code from xpcshell tests, and make them more consistent. All patches will have blanket-rs=places-team and changesets will be annotated here
|
Reporter | |
Updated•14 years ago
|
Assignee: nobody → mak77
Status: NEW → ASSIGNED
|
|
Reporter | |
Comment 1•14 years ago
|
||
cleanup of test_adaptive.js http://hg.mozilla.org/mozilla-central/rev/cee6b068564f
|
|
Reporter | |
Updated•14 years ago
|
Summary: Clean up Place xpcshell tests → Clean up Places xpcshell tests
|
|
Reporter | |
Updated•14 years ago
|
Status: ASSIGNED → NEW
|
|
Reporter | |
Comment 3•14 years ago
|
||
converting to collect changesets for generic Places tests.
Summary: Clean up Places xpcshell tests → Clean up Places tests
|
|
Reporter | |
Comment 4•14 years ago
|
||
fixed some CRLF in a test manifest http://hg.mozilla.org/mozilla-central/rev/cfcd4587cd2e fixed a typo http://hg.mozilla.org/mozilla-central/rev/ab4751fce49a
|
||
Comment 5•13 years ago
|
||
(In reply to comment #4) > fixed a typo > http://hg.mozilla.org/mozilla-central/rev/ab4751fce49a http://hg.mozilla.org/releases/mozilla-1.9.2/rev/fc19169f304d http://hg.mozilla.org/comm-central/rev/929e3d2b3fc8
|
|
Reporter | |
Comment 6•13 years ago
|
||
this just needs a rubberstamp
Attachment #518732 -
Flags: review?(sdwilsh)
|
||
Updated•13 years ago
|
Assignee: nobody → mak77
|
|
||
Comment 7•13 years ago
|
||
Comment on attachment 518732 [details] [diff] [review] cleanup test_browserGlue_migrate.js [checked-in] r=sdwilsh
Attachment #518732 -
Flags: review?(sdwilsh) → review+
|
|
Reporter | |
Comment 8•13 years ago
|
||
Comment on attachment 518732 [details] [diff] [review] cleanup test_browserGlue_migrate.js [checked-in] http://hg.mozilla.org/projects/places/rev/2b7578c84821
Attachment #518732 -
Attachment description: cleanup test_browserGlue_migrate.js → cleanup test_browserGlue_migrate.js [checked-in]
|
|
Reporter | |
Comment 9•13 years ago
|
||
test_342484.xul, cleaned up and removed dependency on a positive setTimeout http://hg.mozilla.org/projects/places/rev/024f5e4df8d5
|
|
Reporter | |
Comment 10•13 years ago
|
||
merged to central test_browserGlue_migrate.js: http://hg.mozilla.org/mozilla-central/rev/2b7578c84821 test_342484.xul http://hg.mozilla.org/mozilla-central/rev/024f5e4df8d5
|
|
Reporter | |
Comment 11•13 years ago
|
||
Cleanup test_update_frecency_after_delete.js and test_412132.js http://hg.mozilla.org/projects/places/rev/a2f4b2f63393 Remove flaky timeout from browser_library_panel_leak.js http://hg.mozilla.org/projects/places/rev/04753538e3b6
|
|
Reporter | |
Updated•13 years ago
|
Assignee: mak77 → nobody
|
|
Reporter | |
Comment 12•13 years ago
|
||
comment 11 merges to central: http://hg.mozilla.org/mozilla-central/rev/04753538e3b6 http://hg.mozilla.org/mozilla-central/rev/a2f4b2f63393
|
|
Reporter | |
Comment 13•13 years ago
|
||
This just cleanups the tests connection in those rare cases it is used, if something should use it for async stuff, it may bring to unwanted warnings and bad stuff. http://hg.mozilla.org/projects/places/rev/52912e2fcd84
|
|
Reporter | |
Comment 14•13 years ago
|
||
Avoid deprecated octal warnings in head_common.js http://hg.mozilla.org/projects/places/rev/95203f83bc25
|
|
Reporter | |
Comment 15•13 years ago
|
||
comment 13 and comment 14 merged. http://hg.mozilla.org/mozilla-central/rev/52912e2fcd84 http://hg.mozilla.org/mozilla-central/rev/95203f83bc25
|
||
Comment 16•13 years ago
|
||
should this be closed now?
|
|
Reporter | |
Comment 17•12 years ago
|
||
yeah, better.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•