557110 - Command-M doesn't minimize window of Mac

Status: RESOLVED FIXED

(Mozilla Labs :: Prism, defect)

Description

[Matthew Gertner]

Standard behavior for apps on OS X is for Command-M to minimize the active application window. This currently doesn't work in Prism.

Comment 1

[Matthew Gertner]

Attachment: Add commandset/keyset for window minimize to main browser XUL

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 436931 [details] [diff] [review]
Add commandset/keyset for window minimize to main browser XUL

>Index: chrome/locale/en-US/browser/baseMenuOverlay.dtd
>===================================================================
>--- chrome/locale/en-US/browser/baseMenuOverlay.dtd	(revision 0)
>+++ chrome/locale/en-US/browser/baseMenuOverlay.dtd	(revision 0)
>@@ -0,0 +1,41 @@
>+<!ENTITY minimizeWindow.key       "m">
>+<!ENTITY minimizeWindow.label     "Minimize">
Why bring in this whole file for just 2 strings? Why not just add the two string to webrunner.dtd?

>Index: chrome/content/webrunner.xul

>+#ifdef XP_MACOSX
>+  <commandset id="baseMenuCommandSet">
>+    <command id="minimizeWindow"
>+      label="&minimizeWindow.label;"
>+      oncommand="window.minimize();" />
>+  </commandset>
>+
>+  <keyset id="baseMenuKeyset">
>+     <key id="key_minimizeWindow"
>+        command="minimizeWindow"
>+        key="&minimizeWindow.key;"
>+        modifiers="accel"/>
>+  </keyset>
>+#endif

Why not put these in the existing commandset and keyset?

Comment 4

[Matthew Gertner]

Attachment: Move command and key to existing commandset/keyset

Comment 5

[Matthew Gertner]

Sending        chrome/content/webrunner.xul
Sending        chrome/jar.mn
Adding         chrome/locale/en-US/browser/baseMenuOverlay.dtd
Transmitting file data ...
Committed revision 65844.