55727 - [CLASSIC] File button (in Messenger) is wacked

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect, P2)

Description

[Jerry Baker]

Build: 2000100720

Open a mail folder or newsgroup in Mozilla with Classic skin. Make sure that 
when the group or folder is opened that no messages are selected. Mouseover the 
"File" button. The icon becomes un-disabled on mouseover, but no button outline.

Now select a message and the "File" button becomes enabled. Mouseover it 
again...no button outline still.

Comment 1

[hangas]

Sending to Joe, this may be related to another File button bug.

Comment 2

[Joe Hewitt (gone)]

I have a fix in hand for this.

Comment 3

[Joe Hewitt (gone)]

I thought at first that this would be an easy fix, but after more careful
analysis I decided that the "right way" to fix this would be a bit more complicated.

The File button is actually a <button> within a <menu>.  This is kinda dumb
considering the existence of the <menubutton> tag.  So, my fix is to replace
this combo with a menubutton.  This required me to add some new XBL bindings and
style rules that weren't there before to handle the case of menubuttons that
should be styled like .button-toolbar-2 buttons.

Comment 4

[Joe Hewitt (gone)]

Attachment: proposed patch

Comment 5

[Joe Hewitt (gone)]

Attachment: proposed patch part 2

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

a=[e-mail]

Comment 7

[Alec Flett]

looks good, r=alecf

Comment 8

[Joe Hewitt (gone)]

fixed

Comment 9

[Patty Mac]

Marking verified on windows (2001-01-24-09-Mtrunk).

Comment 10

[Jerry Baker]

Mass removing self from CC list.

Comment 11

[Jerry Baker]

Now I feel sumb because I have to add back. Sorry for the spam.