Closed
Bug 557358
Opened 14 years ago
Closed 13 years ago
JM: getprop PIC for getters
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla9
People
(Reporter: dmandelin, Assigned: bhackett1024)
References
(Blocks 1 open bug)
Details
(Whiteboard: fixed-in-jaegermonkey)
Attachments
(1 file, 1 obsolete file)
72.97 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
Extend the PIC to handle properties with getters.
Reporter | ||
Updated•14 years ago
|
Comment 1•13 years ago
|
||
This is being a pretty serious performance drag on the DOM. Chris, would you be willing to look at this?
Assignee | ||
Comment 2•13 years ago
|
||
WIP. Handles property ops on GETPROP, not yet GETELEM (should be able to handle the monomorphic case there), and can't yet rejoin from recompilation triggered by the op. function foo(f) { for (var i = 0; i < 5000000; i++) f.caller; } foo(foo); Before After js -m -j -p: 415 188 js -m -n: 630 188
Assignee: general → bhackett1024
Assignee | ||
Updated•13 years ago
|
Assignee | ||
Comment 3•13 years ago
|
||
Handles GETPROP and CALLPROP, not GETELEM. GETELEM is structured somewhat differently and bug 683631 did not identify hot GETELEM on DOM properties with getter hooks.
Attachment #558197 -
Attachment is obsolete: true
Attachment #558355 -
Flags: review?(dvander)
Updated•13 years ago
|
Attachment #558355 -
Flags: review?(dvander) → review+
Assignee | ||
Comment 4•13 years ago
|
||
http://hg.mozilla.org/projects/jaegermonkey/rev/c2726640029f
Whiteboard: fixed-in-jaegermonkey
Assignee | ||
Comment 5•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c02868b913d5
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•13 years ago
|
Target Milestone: --- → mozilla9
You need to log in
before you can comment on or make changes to this bug.
Description
•