557559 - nsDebugImpl.cpp: "warning: enumeration value ‘NS_ASSERT_UNINITIALIZED’ not handled in switch"

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Daniel Holbert [:dholbert]]

Filing bug for this build warning (the only warning for the "xpcom/base/" directory):
{
> xpcom/base/nsDebugImpl.cpp: In function ‘void NS_DebugBreak_P(PRUint32, const char*, const char*, const char*, PRInt32)’:
> xpcom/base/nsDebugImpl.cpp:334: warning: enumeration value ‘NS_ASSERT_UNINITIALIZED’ not handled in switch
}

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

Comment 2

[Benjamin Smedberg]

Comment on attachment 437342 [details] [diff] [review]
fix

We should default to trap if there is nothing else set.

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: fix v2

Ok -- this version groups "NS_ASSERT_UNINITIALIZED" to fall into the "TRAP" case.

Adds a return statement, too, for consistency & foolproofness-against-future-case-statement-rearranging.

Comment 4

[Daniel Holbert [:dholbert]]

http://hg.mozilla.org/mozilla-central/rev/ed68058029e3