Closed
Bug 557670
Opened 14 years ago
Closed 14 years ago
Buttons have over-extending vertical lines -- they shouldn't!
Categories
(addons.mozilla.org Graveyard :: Public Pages, defect)
addons.mozilla.org Graveyard
Public Pages
Tracking
(Not tracked)
VERIFIED
FIXED
5.9
People
(Reporter: stephend, Unassigned)
References
()
Details
(Whiteboard: [z][buttons])
Attachments
(1 file)
27.80 KB,
image/png
|
Details |
See screenshot; there's a weird vertical line on the Add to Firefox/Download Now experiences.
Reporter | ||
Updated•14 years ago
|
Summary: Buttons have vertical lines -- they shouldn't! → Buttons have over-extending vertical lines -- they shouldn't!
Comment 1•14 years ago
|
||
(In reply to comment #0) > See screenshot; there's a weird vertical line on the Add to Firefox/Download Looks like it's caused by the following rule in common-min.css (defined around line 2780 in main.css before minimizing): .section-teaser .addon-view p, .section-teaser .addon-view h3 { margin-left: 0; margin-right: 0; line-height: 1.23em; } That's declaring an explicit line-height, and that smaller line-height is making the icon border overflow the button. Buttons expect the base line-height of 1.538 as declared for the body, but to play it safe we can explicitly declare that line-height for buttons. Fixed in r65389
Reporter | ||
Updated•14 years ago
|
Target Milestone: --- → 5.9
Reporter | ||
Comment 2•14 years ago
|
||
Hey Craig - I've given your Bugzilla account permissions to edit bugs now, so please resolve as needed; thanks.
Comment 3•14 years ago
|
||
(In reply to comment #2) > Hey Craig - I've given your Bugzilla account permissions to edit bugs now, so > please resolve as needed; thanks. Marking as resolved. Thanks, Stephen.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 4•14 years ago
|
||
This needs merging into Zamboni, looks like.
Assignee | ||
Updated•8 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•