557670 - Buttons have over-extending vertical lines -- they shouldn't!

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot of the vertical lines

See screenshot; there's a weird vertical line on the Add to Firefox/Download Now experiences.

Comment 1

[Craig Cook (:craigcook)]

(In reply to comment #0)
> See screenshot; there's a weird vertical line on the Add to Firefox/Download

Looks like it's caused by the following rule in common-min.css (defined around line 2780 in main.css before minimizing):

.section-teaser .addon-view p,
.section-teaser .addon-view h3 {
    margin-left: 0;
    margin-right: 0;
    line-height: 1.23em;
}

That's declaring an explicit line-height, and that smaller line-height is making the icon border overflow the button. Buttons expect the base line-height of 1.538 as declared for the body, but to play it safe we can explicitly declare that line-height for buttons.

Fixed in r65389

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

Hey Craig - I've given your Bugzilla account permissions to edit bugs now, so please resolve as needed; thanks.

Comment 3

[Craig Cook (:craigcook)]

(In reply to comment #2)
> Hey Craig - I've given your Bugzilla account permissions to edit bugs now, so
> please resolve as needed; thanks.

Marking as resolved. Thanks, Stephen.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

This needs merging into Zamboni, looks like.

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED, thanks!