Closed
Bug 557880
Opened 14 years ago
Closed 14 years ago
CodegenLIR: use new opcode names
Categories
(Tamarin Graveyard :: Baseline JIT (CodegenLIR), defect, P4)
Tamarin Graveyard
Baseline JIT (CodegenLIR)
Tracking
(Not tracked)
RESOLVED
FIXED
Future
People
(Reporter: edwsmith, Assigned: edwsmith)
References
Details
Attachments
(3 obsolete files)
Update the JIT to use the new standard opcode names instead of legacy alias names. See the writeup in Bug 504506 - nanojit: The Great Opcode Renaming for details and rationale.
|
Assignee | |
Updated•14 years ago
|
Attachment #437638 -
Attachment is patch: true
Attachment #437638 -
Attachment mime type: application/octet-stream → text/plain
Attachment #437638 -
Flags: review?(wmaddox)
|
|
Assignee | |
Updated•14 years ago
|
|
|
Assignee | |
Updated•14 years ago
|
Attachment #437638 -
Flags: review?(wmaddox) → review?(rreitmai)
|
||
Comment 1•14 years ago
|
||
Seems like we need an updated proposal prior to landing these patches, no? There still seems to be some room for interpretation of the rules outlined in the comments. For example, the load operators mostly look like conversions in this patch, i.e. 'x2y', whereas the store versions do not. loading a byte is ldb2l where store is stb? shouldn't it be stl2b ?
|
|
Assignee | |
Comment 2•14 years ago
|
||
(In reply to comment #1) > Seems like we need an updated proposal prior to landing these patches, no? This patch, perhaps. The opcode renaming of LIRopcode.tbl has already occurred. See comments continued on bug 504506.
|
|
||
Comment 3•14 years ago
|
||
Comment on attachment 437638 [details] [diff] [review] Rename references to LOpcode enums Fair enough.
Attachment #437638 -
Flags: review?(rreitmai) → review+
|
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → edwsmith
|
|
Assignee | |
Updated•14 years ago
|
Attachment #437638 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 4•14 years ago
|
||
Comment on attachment 437638 [details] [diff] [review] Rename references to LOpcode enums TR: http://hg.mozilla.org/tamarin-redux/rev/86450b73d59f
|
|
Assignee | |
Comment 5•14 years ago
|
||
Renames were done mechanically with Eclipse CDT.
Attachment #439528 -
Flags: review?(rreitmai)
|
|
||
Updated•14 years ago
|
Attachment #439528 -
Flags: review?(rreitmai) → review+
|
|
Assignee | |
Comment 6•14 years ago
|
||
Comment on attachment 439528 [details] [diff] [review] Rename LirHelper functions according to new opcode names also: i2p() -> l2p() p2i() -> p2l() u2p() -> ul2up()
|
|
Assignee | |
Comment 7•14 years ago
|
||
TR: http://hg.mozilla.org/tamarin-redux/rev/a86df3624040
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 8•14 years ago
|
||
http://hg.mozilla.org/tamarin-redux/rev/0bd580ce8aeb
|
|
Assignee | |
Updated•14 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 9•14 years ago
|
||
last time for these, again using eclipse's rename refactoring.
Attachment #439528 -
Attachment is obsolete: true
Attachment #441878 -
Flags: review?(rreitmai)
|
|
||
Updated•14 years ago
|
Attachment #441878 -
Flags: review?(rreitmai) → review+
|
|
Assignee | |
Comment 10•14 years ago
|
||
Comment on attachment 441878 [details] [diff] [review] (v2) Rename LirHelper functions according to new opcode names TR: http://hg.mozilla.org/tamarin-redux/rev/256d9d6b3edf
Attachment #441878 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•14 years ago
|
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•