557943 - Searching for addons can result in wrong results

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a4pre) Gecko/20100407 Minefield/3.7a4pre (.NET CLR 3.5.30729)

As it looks like the search algorithm doesn't handle '.' and probably other special characters very well. Searching for ".net" on Windows results in two results: "Microsoft .NET Framework Assistant" and "Default Theme".

The latter one should definitely not be a result for that particular search.

Comment 1

[Tobias (:Tobbi) Markus]

Another search term where incorrect results are reported is for example

"javascript:void()" where all installed add-ons are returned instead of the appropriate number of results.

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

"réf" for Dictionnaire MySpell en Francais (réforme 1990) doesn't find this, but the German dictionary.

Comment 3

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Probably something to do with matching based on word boundaries, rather than whitespace.

See also bug 557701.

Comment 4

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Patch

This changes the matching algorithm to split strings based on whitespace, rather than word boundaries (which was trying to be a bit too smart, and failing miserably).

Note that the test has a couple of todo notes that can be removed once bug 582058 lands.

Comment 5

[Dave Townsend [:mossop]]

Comment on attachment 462367 [details] [diff] [review]
Patch

I'm a little concerned that we're just re-inventing the wheel with this search matching code. For now it seems to be ok but if we start playing whack-a-mole too much we may want to just see if there is some existing open source code that does what we need.

Comment 6

[Dave Townsend [:mossop]]

Landed: http://hg.mozilla.org/mozilla-central/rev/f53e379c3448

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed with Mozilla/5.0 (Windows NT 5.1; rv:2.0b4pre) Gecko/20100810 Minefield/4.0b4pre