558057 - [compare-locales] compare-dirs should support l10n-merge

Status: RESOLVED FIXED

(Mozilla Localizations :: Infrastructure, defect)

Description

[Axel Hecht [:Pike]]

I expect weave to use compare-dirs instead of compare-locales, need to add an option to that so that it supports l10n-merge, too.

Comment 1

[Axel Hecht [:Pike]]

Attachment: add l10n-merge to compare-dirs, error on missing strings without merge

This is a patch that I'd like to have on the production tag, too, so that weave can use the same code as the rest of release.

It's adding the -m option to compare-dirs, passing it down to the worker code the very same way that compare-locales does.
I made File switch the default value of module from None to '', as the latter is fine as an argument to os.path.join(base, module, path). The default value path is not executed as part of compare-locales, but just as part of compare-dirs, so this patch is still pretty much NPOTB.

I copied the return value logic from compare-locales as well, works as expected.

Comment 2

[Chris Cooper [:coop] (he/him)]

Comment on attachment 437874 [details] [diff] [review]
add l10n-merge to compare-dirs, error on missing strings without merge

Looks good.

Comment 3

[Axel Hecht [:Pike]]

Marking FIXED.