Closed
Bug 558182
Opened 14 years ago
Closed 14 years ago
Workers: Don't assume we always get a JSErrorReport in DOMWorkerErrorReporter
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
People
(Reporter: bent.mozilla, Assigned: bent.mozilla)
References
Details
Attachments
(1 file)
5.02 KB,
patch
|
mrbkap
:
review+
beltzner
:
approval1.9.2.4+
beltzner
:
approval1.9.1.10+
|
Details | Diff | Splinter Review |
Blake is going to fix bug 557346 so that we should always have a ucmessage for every JSErrorReport, but we can sometimes not have a JSErrorReport. We should handle that case.
Assignee | ||
Comment 1•14 years ago
|
||
Attachment #437949 -
Flags: review?(mrbkap)
Comment 2•14 years ago
|
||
Comment on attachment 437949 [details] [diff] [review] Patch r=me with those reinterpret_casts that you added.
Attachment #437949 -
Flags: review?(mrbkap) → review+
Assignee | ||
Comment 3•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/94a52b6b6d4e
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 4•14 years ago
|
||
Comment on attachment 437949 [details] [diff] [review] Patch I'd really like to get this on 1.9.2. It fixes the Error object to be useful from workers and has tests.
Attachment #437949 -
Flags: approval1.9.2.4?
Assignee | ||
Updated•14 years ago
|
Attachment #437949 -
Flags: approval1.9.1.10?
Comment 5•14 years ago
|
||
Comment on attachment 437949 [details] [diff] [review] Patch a=beltzner for 1.9.2.4 and 1.9.1.10; Al, should be verified by the automatic tests bent: is there a manual testcase we can use to doublecheck? is that even needed?
Attachment #437949 -
Flags: approval1.9.2.4?
Attachment #437949 -
Flags: approval1.9.2.4+
Attachment #437949 -
Flags: approval1.9.1.10?
Attachment #437949 -
Flags: approval1.9.1.10+
Assignee | ||
Comment 6•14 years ago
|
||
No, no manual test needed.
Assignee | ||
Comment 7•14 years ago
|
||
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/5029d40d15eb
status1.9.2:
--- → .4-fixed
Assignee | ||
Comment 8•14 years ago
|
||
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/9cb32a4624a6
status1.9.1:
--- → .10-fixed
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•