558576 - Build broken in libpr0n due to empty includes (vector/algorithm)

Status: VERIFIED DUPLICATE of bug 557000

(Firefox Build System :: General, defect)

Description

[Marco Perez [:mpk]]

Attachment: GCC_VERSION patch v1 (mozilla-central)

Builds on FreeBSD have been broken for about a week. The error message includes:
../../../dist/stl_wrappers/vector:92:12: error: empty filename in #include
../../../dist/stl_wrappers/algorithm:92:12: error: empty filename in #include

The build falsely assumes that MSVC is being used because GCC_VERSION isn't set.
The attached patch should unbreak the build for every non-tier-1 platform that
uses GCC (with the possible exception of SGI's Irix which had GCC_VERSION set
already).

It would be nice to get some feedback from builders using the Intel compiler on
Linux. I hope this patch doesn't cause any problems using said configuration.
Deferring review request until we can be sure this is not the case.

Comment 1

[Serge Gautherie (:sgautherie)]

Is this issue different than bug 557000?

Comment 2

[Marco Perez [:mpk]]

It's indeed the same issue. And attachment 437811 [details] [diff] [review] from bug 557000 will probably  fix it for all platforms once it gets r+ and lands. Thanks for asking, Serge. :-)

Comment 3

[Serge Gautherie (:sgautherie)]

V.Duplicate