Closed
Bug 558652
Opened 14 years ago
Closed 14 years ago
Port Bug 500328 [Add support for HTML5 History.pushState(), History.replaceState() methods] sessionstore parts to SeaMonkey
Categories
(SeaMonkey :: Session Restore, defect)
SeaMonkey
Session Restore
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.1a1
People
(Reporter: misak.bugzilla, Assigned: misak.bugzilla)
References
Details
Attachments
(1 file, 1 obsolete file)
|
11.13 KB,
patch
|
misak.bugzilla
:
review+
misak.bugzilla
:
superreview+
|
Details | Diff | Splinter Review |
Tests passing in my Fedora 12
Attachment #438352 -
Flags: superreview?(neil)
Attachment #438352 -
Flags: review?(neil)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 438352 [details] [diff] [review] patch plus test >- aWindow.setTimeout(function(){ _this.restoreHistory(aWindow, aTabs, aTabData, aIdMap); }, 0); >+ aWindow.setTimeout(function(){ [Since you're changing it, it would be nice to have a space before the { ] >+ let ident = aDocIdentMap[aEntry.docIdentifier]; >+ if (!ident) { [This will generate a JS strict warning if there is no entry in the map yet. The easiest workaround is not to use the temporary ident variable.]
Attachment #438352 -
Flags: superreview?(neil)
Attachment #438352 -
Flags: superreview+
Attachment #438352 -
Flags: review?(neil)
Attachment #438352 -
Flags: review+
|
Assignee | |
Comment 2•14 years ago
|
||
Neil nits fixed.
Attachment #438352 -
Attachment is obsolete: true
Attachment #438416 -
Flags: superreview+
Attachment #438416 -
Flags: review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Forgot mention, carrying forward r+ sr+ from Neil
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 4•14 years ago
|
||
checking ping
|
|
Assignee | |
Comment 5•14 years ago
|
||
Pushed http://hg.mozilla.org/comm-central/rev/b9dd99c8bf28
|
|
Assignee | |
Updated•14 years ago
|
Target Milestone: --- → seamonkey2.1a1
You need to log in
before you can comment on or make changes to this bug.
Description
•