55876 - Form and Image Manager submenus missing in Tasks menu of subwindows

Status: RESOLVED WORKSFORME

(Toolkit :: Form Manager, defect, P3)

Description

[Blake Ross]

Overview Description:

  There's no Form and Image Manager submenus in Tasks > Privacy and Security 
for subwindows like History, Manage Bookmarks, and Search Bookmarks/History

Steps to Reproduce:
  1) Open the History, Manage Bookmarks or Search Bookmarks/History window.
  2) Tasks > Privacy and Security

Actual Results:   Form Manager and Image Manager are missing (I don't think 
Image Manager should be there in comm builds unless you have the pref enabled)
Expected Results: Tasks > Privacy and Security should be the same throughout 
the app, so those two submenus should be there.

Reproducibility: 100%

Build Date & Platform Bug Found:
  just-pulled win98se

Additional Information:
  There's presumably a missing overlay for these windows.

Comment 1

[Stephen P. Morse]

The removal of the form manager was done in the days when we had "capture form" 
and "prefill form" in the form-manager menu.  It was meaningless to do a 
"capture form" of a bookmark window and it was probably causing a crash.  Why 
the image manager is not displayed is a mystery to me.

It's no longer so terrible to display the form-manager in the menu when in these 
other windows.  But it's still quite useless to do so.  In fact, the entire 
privacy-and-security entry in the task menu should probably not appear when 
looking at any of these subwindows.

So I would probably fix this bug by removing privacy-and-security item in the 
tasks menu rather than by adding back two items from the privacy-and-security 
sub-submenu.

Comment 2

[Blake Ross]

I agree that the user probably doesn't need to look at their form and image 
manager settings while rearranging their bookmarks.  Still, the Tasks menu is 
supposed to be identical every place it appears (for complete consistency), so 
I thought we should just readd the items.

Comment 3

[Stephen P. Morse]

> Tasks menu is supposed to be identical every place it appears 

Where is this written?  I would agree that the items for changing to a different 
task (navigator, mail, composer, address book) should probably be identical 
everywhere.  But there's no justification for the same to be true for 
privacy-and-security.

Comment 4

[Blake Ross]

> Where is this written?

You're the one with the access to all of Netscape's specs, you tell me.  This 
is a major point that Netscape's usability team has been touting for awhile.  
Maybe Vera can help us out here.

For what it's worth, I agree that the Tasks menu should be exactly the same in 
all windows.  Why confuse the user by removing functionality in some places?  
Who's to say that a user should be allowed to view his Address Book cards, but 
not his cookies?  What if I see an URL in my bookmarks list and want to see 
what cookies that site has set?

Comment 5

[verah (gone)]

I don't know what the spec is on this one. I've been advocating getting the Help 
menu correct in those windows (they were putting up a Help menu that didn't 
actually contain a link to the online help!), but that's a different matter -- 
we can reasonably expect that users might want to get help while in those 
windows. As to whether user would want the privacy features while in those 
windows -- well, I can see both Steve and Blake's POVs.

I'd have to defer to the UE people on this one. I'll copy German and ask him to 
take a look at this bug.

Comment 6

[verah (gone)]

Removing myself from list of cc's... since I'm just a wordsmith and not a cool 
UI guy like German.

Comment 7

[Marcia Knous [:marcia]]

Netscape nav triage team: based on Steve Morse's pre-triage recommendation, this 
is not a beta stopper.

Comment 8

[Jesse Ruderman]

>> Tasks menu is supposed to be identical every place it appears 

> Where is this written?  

Let's remove these items from Navigator's Tasks menu, and then we can all be 
happy :)  Bug 67416, '[rfe] turn "Privacy and Security" and "Tools" into one 
top-level menu.'

Btw, see also bug 62615, "image manager, form manager missing from tasks menu 
in composer".  That bug might be a dup of this one.

Comment 9

[german]

yes the items in the tasks menus should _not_ be context specific but always 
consistent across apps. The intent is that this is a general access point to 
functionality in the product and we don't want to ruin people's memory of where 
items where placed by shwoing some items in some contexts but not in others. 
This intent is captured in the task menu section in the older Menu Framework 
spec http://mozilla.org/projects/ui/communicator/framework/menu_framework/

Comment 10

[Stephen P. Morse]

Image manager was explicitly removed from the task menu by cmanske a while back.  
However, due to bug 69669, it was put back.  But I just checked and image 
manager seems to be missing again.  Hmm, this requires more investigation.

Comment 11

[Stephen P. Morse]

*** Bug 62615 has been marked as a duplicate of this bug. ***

Comment 12

[Henrik Gemal]

works for me in 20020213