558945 - Autoscroll doesn't take into account overflow: -moz-hidden-unscrollable;

Status: VERIFIED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Martijn Wargers (dead)]

Attachment: testcase

Besides overflow: hidden, overflow:scroll, overflow:auto and overflow: visible, there is also the computed value of overflow:-moz-hidden-unscrollable.
The new autoscroll code should probably also take that into account, because now autoscrolling doesn't work with those values.

Comment 1

[Arpad Borsos [:Swatinem]]

Attachment: fix [pushed: comment 4]

Instead of disallowing scrolling on "hidden" or "visible", I changed it around to allow scrolling only when "scroll" or "auto" is present.
Are there any other special values I need to be aware of?

Comment 2

[Martijn Wargers (dead)]

See https://developer.mozilla.org/en/CSS/overflow
It turns out there are also these values:
-moz-scrollbars-none, -moz-scrollbars-horizontal and -moz-scrollbars-vertical.
But for those values, the computed values are 'converted' into 'hidden' and 'scroll', so they already work correctly.

Comment 3

[[e-mail]]

Comment on attachment 438699 [details] [diff] [review]
fix [pushed: comment 4]

>+            // this is a list of values to the overflow property that allow
>+            // scrolling
s/values to the overflow property/overflow property values/
(does that allow you to fit the comment in on one line? if not my other suggestion is // this is a list of scrollable overflow property values)

Comment 4

[Arpad Borsos [:Swatinem]]

Comment on attachment 438699 [details] [diff] [review]
fix [pushed: comment 4]

Pushed with comment adressed: http://hg.mozilla.org/mozilla-central/rev/d51871338856
Thanks!

Comment 5

[Martijn Wargers (dead)]

Verified fixed, using:
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a5pre) Gecko/20100419 Minefield/3.7a5pre

Thanks Arpad.