559628 - Use of <limits> in ctypes breaks android build

Status: RESOLVED WONTFIX

(Core :: js-ctypes, defect)

Description

[Michael Wu [:mwu]]

Bionic doesn't provide the limits header or std::numeric_limits.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Hmm...  Can we provide a shim?  We have some content/ patches in flight that would use the limits header and std::numeric_limits, iirc.

Comment 2

[Michael Wu [:mwu]]

I think it might be possible, especially for limits which seems relatively simple. See also bug 556839 since we'll need to fix this issue to use e10s.

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

We'll need to fix this before we pull in a version of STL into the tree.

Comment 4

[Michael Wu [:mwu]]

We can probably borrow some appropriately licensed limits header or make our own. Rewriting code to not use std::numeric_limits isn't much of an option since the alternative is so much worse.

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

wontfixing this -- we'll have workarounds for STL in android (initially an alternate ndk, eventually an in-tree STL).