Closed
Bug 559746
Opened 14 years ago
Closed 12 years ago
add a11y mochitests for <input type="tel">
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: surkov, Assigned: maxli)
References
(Depends on 1 open bug, Blocks 1 open bug, )
Details
(Whiteboard: [good first bug][mentor=surkov.alexander@gmail.com][lang=js])
Attachments
(1 file)
3.85 KB,
patch
|
surkov
:
review+
|
Details | Diff | Splinter Review |
It's going to be autocomplete text field. We should expose it as COMBOBOX role and make sure STATE_INVALID is managed properly.
Reporter | ||
Comment 1•14 years ago
|
||
Autocomplete stuffs should be covered by bug 559766
Depends on: 559766
Reporter | ||
Comment 2•12 years ago
|
||
It should be exposed as text entry with autocomplete state now. So all we should do is to add mochitest (add to states/test_inputs at autocomplete testing part and to tree/test_txtctrl.html).
Whiteboard: [good first bug][mentor=surkov.alexander@gmail.com][lang=js]
Reporter | ||
Updated•12 years ago
|
Summary: make <input type="tel"> accessible → add a11y mochitests for <input type="tel">
Assignee | ||
Comment 3•12 years ago
|
||
Assignee: nobody → maxli
Attachment #612060 -
Flags: review?(surkov.alexander)
Reporter | ||
Comment 4•12 years ago
|
||
Comment on attachment 612060 [details] [diff] [review] Patch v1 Review of attachment 612060 [details] [diff] [review]: ----------------------------------------------------------------- I'll fix those before landing, thank you! ::: accessible/tests/mochitest/states/test_inputs.html @@ +160,5 @@ > + <a target="_blank" > + href="https://bugzilla.mozilla.org/show_bug.cgi?id=559746" > + title="add a11y mochitests for <input type='tel'>"> > + Mozilla Bug 559746 > + </a> well, I think it's not necessary since it was just mochitest ::: accessible/tests/mochitest/tree/test_txtctrl.html @@ +117,5 @@ > + <a target="_blank" > + href="https://bugzilla.mozilla.org/show_bug.cgi?id=559746" > + title="add a11y mochitests for <input type='tel'>"> > + Mozilla Bug 559746 > + </a> same
Attachment #612060 -
Flags: review?(surkov.alexander) → review+
Reporter | ||
Comment 5•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4b20ef3e8e8a
Reporter | ||
Updated•12 years ago
|
Target Milestone: --- → mozilla14
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4b20ef3e8e8a
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•